From owner-freebsd-fs@FreeBSD.ORG Wed Jul 10 18:13:14 2013 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 29E1C31D; Wed, 10 Jul 2013 18:13:14 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) by mx1.freebsd.org (Postfix) with ESMTP id 12FF4120B; Wed, 10 Jul 2013 18:13:13 +0000 (UTC) Received: from zeta.ixsystems.com (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 76ECB9DEA; Wed, 10 Jul 2013 11:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1373479993; bh=FjIMYhZ22un7bkY8tLUyfXF6Kw82/IJxBZuDu/11fGg=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=cI/vIr2mBorhCFAMuqfi4qLnifvdXjcGZNUtC8yUr40f6siCjnr0d5ICNur5B3ErI qWIrspOqjADKHiBsismW2/z0wb/kXm/EkZLNF+mU4y8UDSWUwuDeyqY3nVq5UpiH4L tJbID7e7paQLNlS9mByFjRD/QBC9vPt6/7mZim1o= Message-ID: <51DDA433.7040707@delphij.net> Date: Wed, 10 Jul 2013 11:13:07 -0700 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: "Justin T. Gibbs" Subject: Re: Make ZFS use the physical sector size when computing initial ashift References: <86zjtupz3r.fsf@nine.des.no> <51DD9801.4090808@delphij.net> <2B9367B6-8759-45C9-B120-9D00A381228F@FreeBSD.org> In-Reply-To: <2B9367B6-8759-45C9-B120-9D00A381228F@FreeBSD.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= , d@delphij.net, ivoras@freebsd.org, freebsd-hackers@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: d@delphij.net List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jul 2013 18:13:14 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 07/10/13 10:38, Justin T. Gibbs wrote: [snip] > I'm sure lots of folks have "some solution" to this. Here is an > old version of what we use at Spectra: > > http://people.freebsd.org/~gibbs/zfs_patches/zfs_auto_ashift.diff > > The above patch is missing some cleanup that was motivated by my > discussions with George Wilson about this change in April. I'll > dig that up later tonight. Even if you don't read the full diff, > please read the included checkin comment since it explains the > motivation behind this particular solution. > > This is on my list of things to upstream in the next week or so > after I add logic to the userspace tools to report whether or not > the TLVs in a pool are using an optimal allocation size. This is > only possible if you actually make ZFS fully aware of logical, > physical, and the configured allocation size. All of the other > patches I've seen just treat physical as logical. Yes, me too. Your version is superior. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJR3aQzAAoJEG80Jeu8UPuzHn8H/1ZpoTqAQ4+mgQOttOwXgBcr 2Fgh52ztW8fCEQSeIosxXKO06hP7HxFfTPvmeeWyjT8zIpSUSFV6G0NclebKDncP huGFofvx3BKPRmfzZp4iZx1wWQUxSHTmv6ceDwvP7P8GJ0mON+SrZxmmwUjKrf7V W9Sazl0p8e0nxSQykLyjjrkaBx5Iv+aUxu8Alomwy9BmpM8+gd2yutvzghW5L36L 0CvAtIMXdlc+eUdAqa/2rOk/nMOA9sfWVW0gkKYCZk6wvj2DMzjii05UechZ4Z+l 6nEU3UdVsbTX73CABZv4my4JAWc5Yk1s/cWrxtn68AfK8LMPFJCJcVXXOSckMWI= =351W -----END PGP SIGNATURE-----