From owner-freebsd-hackers@FreeBSD.ORG Sun Oct 16 13:36:16 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 973BD1065674 for ; Sun, 16 Oct 2011 13:36:16 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 1AC858FC0C for ; Sun, 16 Oct 2011 13:36:15 +0000 (UTC) Received: by wwi18 with SMTP id 18so1962385wwi.31 for ; Sun, 16 Oct 2011 06:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=BpMwV0mmgLtV2JMjioLZS4bmRVMccqKWQxQePufh6b8=; b=fZ9OYcsYo0boP34/A+wx7SSYavS31mltPbL2UKYDV51jca/F0rETm/uPQO+O8SuXKS te7h95RKynqtsUMNwZTfNZEtvqDa8NSI5BFCRgRG3rReCd75CcWXAGWwQwY7YXnugE7M 9LoMJjOSVmYzPnT8uWuQ/7eW11alMa++t64os= Received: by 10.227.120.205 with SMTP id e13mr4897395wbr.98.1318772175091; Sun, 16 Oct 2011 06:36:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.200.72 with HTTP; Sun, 16 Oct 2011 06:35:45 -0700 (PDT) In-Reply-To: References: From: Eitan Adler Date: Sun, 16 Oct 2011 09:35:45 -0400 Message-ID: To: Benjamin Kaduk Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD Hackers Subject: Re: rtadvd - WARNS and a missing break? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2011 13:36:16 -0000 On Sat, Oct 15, 2011 at 10:01 PM, Benjamin Kaduk wrote: > On Sat, 15 Oct 2011, Eitan Adler wrote: > >> I was playing around with WARNS on some programs and noticed that >> usr.sbin/rtadvd builds with WARNS=3 with both clang and gcc (and >> WARNS=6 with gcc). Perhaps the following could be committed ? > > WARNS changes should be verified by make universe; was that your testing? It wasn't. However after getting your email I ran make universe and it appears all builds were successful. > > -Ben Kaduk > -- Eitan Adler