From nobody Sun Oct 26 17:02:01 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cvjc82jhrz6DZly; Sun, 26 Oct 2025 17:02:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cvjc76M49z3rS7; Sun, 26 Oct 2025 17:02:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 59QH21pX094988; Sun, 26 Oct 2025 19:02:04 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 59QH21pX094988 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 59QH21RO094987; Sun, 26 Oct 2025 19:02:01 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 26 Oct 2025 19:02:01 +0200 From: Konstantin Belousov To: Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6d408ac49073 - main - fusefs: add a regression test for a cluster_read bug Message-ID: References: <202510231341.59NDf5as007410@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cvjc76M49z3rS7 On Sun, Oct 26, 2025 at 10:53:05AM -0600, Alan Somers wrote: > On Fri, Oct 24, 2025 at 2:13 AM Konstantin Belousov > wrote: > > > On Thu, Oct 23, 2025 at 01:41:05PM +0000, Alan Somers wrote: > > > The branch main has been updated by asomers: > > > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=6d408ac490730614b3ed0ebd3caffcd23f303fb4 > > > > > > commit 6d408ac490730614b3ed0ebd3caffcd23f303fb4 > > > Author: Alan Somers > > > AuthorDate: 2025-10-23 13:40:56 +0000 > > > Commit: Alan Somers > > > CommitDate: 2025-10-23 13:40:56 +0000 > > > > > > fusefs: add a regression test for a cluster_read bug > > > > > > VOP_BMAP is purely advisory. If VOP_BMAP returns an error during > > > readahead, cluster_read should still succeed, because the actual data > > > was still read just fine. > > No, VOP_BMAP() is not advisory. But read-ahead beyond the first buffer is. > > The BMAP in question is to translate lblk for read-ahead buffer. > > > > > The FUSE_WRITE request _always_ includes the file's nodeid and offset. So > unlike, say, UFS, FUSE_BMAP is only used to make decisions about > clustering, to compute the amount of readahead. So I suppose I should've > said that "FUSE_BMAP is purely advisory". Thanks for the correction. I would say that the specific instance of the VOP_BMAP() call is allowed to fail.