From owner-freebsd-hackers@FreeBSD.ORG Sun Jul 30 20:03:11 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDCD416A4DE for ; Sun, 30 Jul 2006 20:03:11 +0000 (UTC) (envelope-from tijl@ulyssis.org) Received: from outmx013.isp.belgacom.be (outmx013.isp.belgacom.be [195.238.5.64]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C70B43D46 for ; Sun, 30 Jul 2006 20:03:11 +0000 (GMT) (envelope-from tijl@ulyssis.org) Received: from outmx013.isp.belgacom.be (localhost [127.0.0.1]) by outmx013.isp.belgacom.be (8.12.11.20060308/8.12.11/Skynet-OUT-2.22) with ESMTP id k6UK333h001097 for ; Sun, 30 Jul 2006 22:03:03 +0200 (envelope-from ) Received: from kalimero.kotnet.org (64.211-245-81.adsl-dyn.isp.belgacom.be [81.245.211.64]) by outmx013.isp.belgacom.be (8.12.11.20060308/8.12.11/Skynet-OUT-2.22) with ESMTP id k6UK30pN001071; Sun, 30 Jul 2006 22:03:00 +0200 (envelope-from ) Received: from kalimero.kotnet.org (kalimero.kotnet.org [127.0.0.1]) by kalimero.kotnet.org (8.13.6/8.13.6) with ESMTP id k6UK2snk016088; Sun, 30 Jul 2006 22:03:00 +0200 (CEST) (envelope-from tijl@ulyssis.org) From: Tijl Coosemans To: kmacy@fsmware.com Date: Sun, 30 Jul 2006 22:02:50 +0200 User-Agent: KMail/1.9.3 References: <200607292110.37733.tijl@ulyssis.org> <200607301834.16657.tijl@ulyssis.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2788921.PdlsaWxk3Z"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200607302202.54315.tijl@ulyssis.org> Cc: freebsd-hackers@freebsd.org Subject: Re: i386 page fault clobbers error code in trap frame X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 20:03:11 -0000 --nextPart2788921.PdlsaWxk3Z Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 30 July 2006 21:30, Kip Macy wrote: > > si_addr doesn't contain the faulting pc, it contains the address > > that > > So either the comment is wrong, or that is a technically incorrect > kludge. However, given that a number of the other fields are not > filled out at all, the real objective should be to keep applications > working. Well, the comment is correct except in case of a page fault. But this is=20 different from stable. In stable si_addr is a copy of tf_err, which,=20 because of the kludge, holds the fault address in case of a page=20 fault... I'm glad to see this code has been cleaned up. --nextPart2788921.PdlsaWxk3Z Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQBEzRBudMR2xnarec8RAmj6AJ9u2EP4NlScRtKMU7LiScozggiSkwCdG4EH bqfg49dxTUj5GCpTqcYpYJs= =WqkR -----END PGP SIGNATURE----- --nextPart2788921.PdlsaWxk3Z--