From owner-freebsd-current@FreeBSD.ORG Tue Aug 23 21:23:23 2011 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2162F106564A; Tue, 23 Aug 2011 21:23:23 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id CAB9E8FC12; Tue, 23 Aug 2011 21:23:22 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id B64AABDF; Tue, 23 Aug 2011 23:23:20 +0200 (CEST) Date: Tue, 23 Aug 2011 23:23:03 +0200 From: Pawel Jakub Dawidek To: Rick Macklem Message-ID: <20110823212301.GE1697@garage.freebsd.pl> References: <20110823151041.GA1697@garage.freebsd.pl> <1614657395.247867.1314130280524.JavaMail.root@erie.cs.uoguelph.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OZkY3AIuv2LYvjdk" Content-Disposition: inline In-Reply-To: <1614657395.247867.1314130280524.JavaMail.root@erie.cs.uoguelph.ca> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Hiroki Sato , current@FreeBSD.org, Benjamin Kaduk Subject: Re: fsid change of ZFS? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2011 21:23:23 -0000 --OZkY3AIuv2LYvjdk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 23, 2011 at 04:11:20PM -0400, Rick Macklem wrote: > Pawel Jakub Dawidek wrote: > > On Tue, Aug 23, 2011 at 10:09:41AM -0400, Rick Macklem wrote: > > > Ok, I'll admit I wasn't very fond of a fixed table that would > > > inevitably > > > get out of date someday, either. > > > > > > I didn't think hashing for the cases not in the table was worth the > > > effort, > > > but doing a hash instead of a table seems reasonable. > > > > > > I see that ZFS only uses the low order 8 bits, so I'll try and come > > > up > > > with an 8bit hash solution and will post a patch for testing/review > > > soon. > > > > > > I don't think the vfs_sysctl() is that great a concern, given that > > > it > > > appears to be deprecated already anyhow. (With an 8bit hash, > > > vfs_typenum > > > won't be that sparse.) I'll also make sure that whatever hash I use > > > doesn't collide for the current list of file names (although I will > > > include > > > code that handles a collision in the patch). > >=20 > > Sounds great. Thanks! > >=20 > Here's the patch. (Hiroki could you please test this, thanks, rick.) > ps: If the white space gets trashed, the same patch is at: > http://people.freebsd.org/~rmacklem/fsid.patch The patch is fine by me. Thanks, Rick! --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --OZkY3AIuv2LYvjdk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk5UGjUACgkQForvXbEpPzT0IACg4xRtqasZSLUzwefpWztWkkAc xtUAniO6KmXQCSIAUmBPksSKEj4hQDfc =MM+u -----END PGP SIGNATURE----- --OZkY3AIuv2LYvjdk--