From owner-freebsd-hackers@FreeBSD.ORG Mon Apr 16 18:24:58 2007 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 27EAA16A40B for ; Mon, 16 Apr 2007 18:24:58 +0000 (UTC) (envelope-from zhangweiwu@realss.com) Received: from bossdog.realss.com (bossdog.realss.com [211.157.108.128]) by mx1.freebsd.org (Postfix) with ESMTP id D386013C4C6 for ; Mon, 16 Apr 2007 18:24:57 +0000 (UTC) (envelope-from zhangweiwu@realss.com) Received: from localhost (unknown [127.0.0.1]) by bossdog.realss.com (Postfix) with ESMTP id C7622238045 for ; Tue, 17 Apr 2007 02:24:59 +0800 (CST) Received: from bossdog.realss.com ([127.0.0.1]) by localhost (bossdog.realss.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 16105-16 for ; Tue, 17 Apr 2007 02:24:59 +0800 (CST) Received: from [192.168.1.200] (58.52.72.124.board.xm.fj.dynamic.163data.com.cn [124.72.52.58]) by bossdog.realss.com (Postfix) with ESMTP id D36AF1C000A for ; Tue, 17 Apr 2007 02:24:58 +0800 (CST) Message-ID: <4623BF5E.7000907@realss.com> Date: Tue, 17 Apr 2007 02:24:30 +0800 From: Zhang Weiwu User-Agent: Thunderbird 1.5.0.7 (X11/20060918) MIME-Version: 1.0 To: freebsd-hackers@freebsd.org References: <1176725221.17708.16.camel@joe.realss.com> <200704161910.17794.pieter@degoeje.nl> In-Reply-To: <200704161910.17794.pieter@degoeje.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: amavisd-new at bossdog.realss.com Subject: Re: a simple patch to enable RFC2640 for /usr/libexec/ftpd X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2007 18:24:58 -0000 Pieter de Goeje 写道: > I think your patch looks good, however there have been some changes to ftpd > since 6.1. Also, since lukemftp is imported from NetBSD, you might want to > contact the original author so future imports won't discard this new feature. > Original author of lukemftp? I never used that software before, but would be glad to try as next option and see if I can patch that too. You already discovered (by checking my patch) I am a C newbie who only wish to solve his own problem at hand... > On Monday 16 April 2007, Zhang Weiwu wrote: > >> family = (family == AF_INET) ? AF_UNSPEC : >> AF_INET6; break; >> + >> + case '8': >> + utf8_mode = 1; >> > Add missing break statement here? > Yes. A break is missing:)