From owner-freebsd-current@FreeBSD.ORG Thu Apr 1 21:22:44 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3AF51065673 for ; Thu, 1 Apr 2010 21:22:44 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 840418FC20 for ; Thu, 1 Apr 2010 21:22:44 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id D1D1D1FFC5D; Thu, 1 Apr 2010 21:22:42 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 1B92F846E2; Thu, 1 Apr 2010 15:30:47 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Xin LI References: <4BA7E0B8.3080406@delphij.net> <4BAE2B4F.6060005@protected-networks.net> <4BB3FD5D.9070600@uffner.com> Date: Thu, 01 Apr 2010 15:30:47 +0200 In-Reply-To: (Xin LI's message of "Wed, 31 Mar 2010 20:51:58 -0700") Message-ID: <86tyrvs3js.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: HEADSUP: zlib updated [svn commit: r205471 - in head: . lib/libz lib/libz/contrib lib/libz/doc sys/sys] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 21:22:44 -0000 Xin LI writes: > Tom Uffner writes: > > Michael Butler writes: > > > This breaks most (if not all) of the QT4-dependent ports for the > > > lack of a definition of "off64_t". > > it also breaks multimedia/mplayer, graphics/ImageMagick, and > > print/ghostscript8 & everything that depends on it. > Just because they used to compile DOES NOT mean they were right. It's > NOT right to define _LARGEFILE64_SOURCE on FreeBSD, see: > > http://www.delorie.com/gnu/docs/glibc/libc_13.html Nor is it correct on Linux. As the above link says, _LARGEFILE64_SOURCE is a hack that was introduced to ease the transition from 32-bit off_t to 64-bit off_t. The correct idiom is to define _FILE_OFFSET_BITS to 64 before including and . http://www.delorie.com/gnu/docs/glibc/libc_13.html That was *fourteen years ago*, almost to the day. There is *no* excuse for using this hack today. *Especially* in software that was written long after that document was published. *Especially* when all you need to do to get it right is add AC_SYS_LARGEFILE to configure.ac and use off_t, struct stat and stat() / lstat() (without the "64" suffix) as if none of this had ever happened. And yes, I *will* keep harping on this until people Get It. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no