From owner-p4-projects@FreeBSD.ORG  Tue Feb 21 15:31:58 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 10F0216A423; Tue, 21 Feb 2006 15:31:58 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C4BC316A420
	for <perforce@freebsd.org>; Tue, 21 Feb 2006 15:31:57 +0000 (GMT)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6C62443D48
	for <perforce@freebsd.org>; Tue, 21 Feb 2006 15:31:57 +0000 (GMT)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k1LFVv93042241
	for <perforce@freebsd.org>; Tue, 21 Feb 2006 15:31:57 GMT
	(envelope-from csjp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k1LFVvme042238
	for perforce@freebsd.org; Tue, 21 Feb 2006 15:31:57 GMT
	(envelope-from csjp@freebsd.org)
Date: Tue, 21 Feb 2006 15:31:57 GMT
Message-Id: <200602211531.k1LFVvme042238@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	csjp@freebsd.org using -f
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 92128 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Feb 2006 15:31:58 -0000

http://perforce.freebsd.org/chv.cgi?CH=92128

Change 92128 by csjp@csjp_xor on 2006/02/21 15:31:43

	Do not ignore the return value of au_write. This function can fail so we
	should make sure it doesn't, but if it does, do the right thing.

Affected files ...

.. //depot/projects/trustedbsd/audit3/usr.bin/login/login_audit.c#14 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/usr.bin/login/login_audit.c#14 (text+ko) ====

@@ -110,13 +110,21 @@
 		syslog(LOG_AUTH | LOG_ERR, "au_to_subject32 failed");
 		errx(1, "Permission denied");
 	}
-	au_write(aufd, tok);
+	if (au_write(aufd, tok) < 0) {
+		syslog(LOG_AUTH | LOG_ERR, "au_write faied: %s",
+		    strerror(errno));
+		errx(1, "Permission denied");
+	}
 
 	if ((tok = au_to_return32(0, 0)) == NULL) {
 		syslog(LOG_AUTH | LOG_ERR, "au_to_return32 failed");
 		errx(1, "Permission denied");
 	}
-	au_write(aufd, tok);
+	if (au_write(aufd, tok) < 0) {
+		syslog(LOG_AUTH | LOG_ERR, "au_write faied: %s",
+		    strerror(errno));
+		errx(1, "Permission denied");
+	}
 
 	if (au_close(aufd, 1, AUE_login) == -1) {
 		syslog(LOG_AUTH | LOG_ERR, "audit record not committed");
@@ -176,21 +184,33 @@
 			errx(1, "Permission denied");
 		}
 	}
-	au_write(aufd, tok);
+	if (au_write(aufd, tok) < 0) {
+		syslog(LOG_AUTH | LOG_ERR, "au_write faied: %s",
+		    strerror(errno));
+		errx(1, "Permission denied");
+	}
 
 	/* Include the error message. */
 	if ((tok = au_to_text(errmsg)) == NULL) {
 		syslog(LOG_AUTH | LOG_ERR, "au_to_text failed");
 		errx(1, "Permission denied");
 	}
-	au_write(aufd, tok);
+	if (au_write(aufd, tok) < 0) {
+		syslog(LOG_AUTH | LOG_ERR, "au_write faied: %s",
+		    strerror(errno));
+		errx(1, "Permission denied");
+	}
 
 	if ((tok = au_to_return32(1, errno)) == NULL) {
 		syslog(LOG_AUTH | LOG_ERR,
 		    "login: Audit Error: au_to_return32() failed");
 		errx(1, "Permission denied");
 	}
-	au_write(aufd, tok);
+	if (au_write(aufd, tok) < 0) {
+		syslog(LOG_AUTH | LOG_ERR, "au_write faied: %s",
+		    strerror(errno));
+		errx(1, "Permission denied");
+	}
 
 	if (au_close(aufd, 1, AUE_login) == -1) {
 		syslog(LOG_AUTH | LOG_ERR,
@@ -240,14 +260,22 @@
 		    "login: Audit Error: au_to_subject32() failed");
 		errx(1, "Permission denied");
 	}
-	au_write(aufd, tok);
+	if (au_write(aufd, tok) < 0) {
+		syslog(LOG_AUTH | LOG_ERR, "au_write faied: %s",
+		    strerror(errno));
+		errx(1, "Permission denied");
+	}
 
 	if ((tok = au_to_return32(0, 0)) == NULL) {
 		syslog(LOG_AUTH | LOG_ERR,
 		    "login: Audit Error: au_to_return32() failed");
 		errx(1, "Permission denied");
 	}
-	au_write(aufd, tok);
+	if (au_write(aufd, tok) < 0) {
+		syslog(LOG_AUTH | LOG_ERR, "au_write faied: %s",
+		    strerror(errno));
+		errx(1, "Permission denied");
+	}
 
 	if (au_close(aufd, 1, AUE_logout) == -1) {
 		syslog(LOG_AUTH | LOG_ERR, "Audit Record was not committed.");