From owner-cvs-all@FreeBSD.ORG Mon Jul 7 17:39:38 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A9AD1065680 for ; Mon, 7 Jul 2008 17:39:38 +0000 (UTC) (envelope-from fjoe@samodelkin.net) Received: from atlas57.myplace.ru (atlas57.myplace.ru [80.66.68.57]) by mx1.freebsd.org (Postfix) with ESMTP id 6F88B8FC23 for ; Mon, 7 Jul 2008 17:39:37 +0000 (UTC) (envelope-from fjoe@samodelkin.net) Received: (qmail 64681 invoked from network); 8 Jul 2008 00:26:32 +0700 Received: from host89-251-107-5.hnet.ru (HELO husky.fjoe.local) (89.251.107.5) by atlas57.myplace.ru with (DHE-RSA-AES256-SHA encrypted) SMTP; 8 Jul 2008 00:26:32 +0700 Message-ID: <487251C7.7060102@samodelkin.net> Date: Tue, 08 Jul 2008 00:26:31 +0700 From: Max Khon User-Agent: Thunderbird 2.0.0.12 (X11/20080326) MIME-Version: 1.0 To: Pietro Cerutti References: <200807071617.m67GHsHA058914@repoman.freebsd.org> <48724635.80406@FreeBSD.org> In-Reply-To: <48724635.80406@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Max Khon , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/dmucs Makefile ports/devel/dmucs/files patch-dmucs_db.cc patch-dmucs_db.h patch-dmucs_msg.cc patch-main.cc X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2008 17:39:38 -0000 Hello! Pietro Cerutti wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Max Khon wrote: > | fjoe 2008-07-07 16:17:54 UTC > | > | FreeBSD ports repository > | > | Modified files: > | devel/dmucs Makefile > | Added files: > | devel/dmucs/files patch-dmucs_db.cc patch-dmucs_db.h > | patch-dmucs_msg.cc patch-main.cc > | Log: > | Unbreak on 64-bit archs > > I definitely do not agree. Please note that a pointer is not required to > fit into a long, while it is required to fit into a size_t. > > Your solution may work as soon as we are concerned only with LP64 > machines. As soon as a LLP64 arch steps in, you break things. AFAIK it is not guaranteed that sizeof(void *) <= sizeof(size_t) too. I used "long" because I did not want to cope with "[u]intptr_t" there. Ok, I committed a modified patch that uses "const void *" instead of "long". /fjoe