From owner-freebsd-bugs@freebsd.org Wed Oct 21 17:40:13 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA7CEA1BC76 for ; Wed, 21 Oct 2015 17:40:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7DC8F1AFE for ; Wed, 21 Oct 2015 17:40:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t9LHeDuN080311 for ; Wed, 21 Oct 2015 17:40:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 203938] makefs: Coverity CID 975345, 975346: No provisions for i/o error Date: Wed, 21 Oct 2015 17:40:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: scdbackup@gmx.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 17:40:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203938 Bug ID: 203938 Summary: makefs: Coverity CID 975345, 975346: No provisions for i/o error Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: scdbackup@gmx.net usr.sbin/makefs/cd9660/cd9660_debug.c CID 975346 (#1 of 2): Ignoring number of bytes read (CHECKED_RETURN) 3. check_return: fread(void * restrict, size_t, size_t, FILE * restrict) returns the number of bytes read, but it is ignored. 208 fread(((unsigned char*)&pttemp) + 8, 1, pttemp.length[0], fd); CID 975345 (#1 of 1): Ignoring number of bytes read (CHECKED_RETURN) 2. check_return: fread(void * restrict, size_t, size_t, FILE * restrict) returns the number of bytes read, but it is ignored. 238 fread(buf, 1, CD9660_SECTOR_SIZE, fd); --------------- Source analysis: Indeed one should check for complete read success. Just above the fread() calls, fseeko() failure leads to err(): 200 if (fseeko(fd, CD9660_SECTOR_SIZE * sector, SEEK_SET) == -1) 201 err(1, "fseeko"); 236 if (fseeko(fd, CD9660_SECTOR_SIZE * sector, SEEK_SET) == -1) 237 err(1, "fseeko"); --------------- Remedy proposal: One should distinguish between EOF and error. - fread(((unsigned char*)&pttemp) + 8, 1, pttemp.length[0], fd); + if (fread(((unsigned char*)&pttemp) + 8, 1, pttemp.length[0], + fd) != pttemp.length[0]) { + if (feof(fd)) + err(1, "EOF on fread"); + err(1, "Error on fread"); + } - fread(buf, 1, CD9660_SECTOR_SIZE, fd); + if (fread(buf, 1, CD9660_SECTOR_SIZE, fd) != + CD9660_SECTOR_SIZE) { + if (feof(fd)) + err(1, "EOF on fread"); + err(1, "Error on fread"); + } -- You are receiving this mail because: You are the assignee for the bug.