From nobody Tue Dec 2 16:01:35 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dLQW32MJgz6Hghx for ; Tue, 02 Dec 2025 16:01:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dLQW31Lb8z4Q4d for ; Tue, 02 Dec 2025 16:01:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764691295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yLDNtRd+VnlDM5wC0AOz/fV2GBYLY2v3eAoHJv12HI8=; b=qbZMtfAWBGEhFud6cR2dfPPTnJsC+BMhcEIp4sZAVPKc/FgGJVxDilecHrKWlBFFf0+5aO DwkeGbPteQSkOmSrZKmFVvRMCHoN6ueu4dWiMMldDVOu3lEw07iHBmD6gh1hV1ArmXK4YE DNlmLaGZUtf7scA232eZ7dF+sVRwohSFEW7kWQ17ZzeWIFZOJ6dlJSKgqdecbynQNsPnCH AKpXE497Iq9yWlqbFTMwLQHTBuQDEi1qUpDGU/PAlIAaX40sdr4x9fASX4vk15PMFsdWWl YJPWhTK/Hg1rcp4z6dGY/2foVwhQAJcgVqjWmYXP0T5PRZcMc/jyYtqHAbCUKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764691295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yLDNtRd+VnlDM5wC0AOz/fV2GBYLY2v3eAoHJv12HI8=; b=nrrZMq40fSUuxhno7IW4pS5KjNDjQQzy+55zwTaP7OIHJ5eS0M3k6OHnRXn1oBWVC35lLa 5jmZ0IPYkIpageOMpqgorfyv8ZsTONMGMfmEVo8Dkz0vUIet8vlKnBufT2PgVuaeA3A08a jhNSaj2vGbkTA4GZj1JK1KsX3rW+X2PRYrmO1Dg0FmHUXUJ3lR7EoxpeoYIz3Qb9C0TrOv BN31MF5Ekt/57L5gHq8sFbmrraKbLgWgF2A2KlVT5dkSI0Dw+yUeJe0COKmhUMMhoiw+7H +se74LUqrkuan3H7brO5u8BZPuCUW8ty0n2mNruUnHOwTt0bJ1CPv0pCS32diA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764691295; a=rsa-sha256; cv=none; b=neVl3sBybOypApZh2GXv78uekMbxMm3rwCiZNDpy0iCTxg8AZhKLDpICH272lepM2Noga0 F3ak9rX/JAroPeEsj1XUPQLAMGJuoWlDmV9+ELvawo3sHjHKfeGXUwZi8arEg0TBrpCUMZ pZ451Hyki+CxQ9ZulAcqcSzJyyTVEQblblyyD4suCsmMrl2gcXpuID3QdK5Fy6uBBQlNs0 QJgzQRWBuVkrB9xNHHmh59oOX3ZpklLpeMU2FMUr53O/MF/9fZJg5x3Z1La03zawYhp2X2 Cey+ulKyZyXBsUyW0bT3VVKvy97r488dqfZTNBVCf+jY2DBZl9Ig3WqBZLXM0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dLQW30sKpz1CmS for ; Tue, 02 Dec 2025 16:01:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3878d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 02 Dec 2025 16:01:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 44d6df4f65b1 - main - nvme: Use memcpy instead of memmove in nvme_cdata_get_disk_ident List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 44d6df4f65b1441cf9cd9f12cd41edd52205d084 Auto-Submitted: auto-generated Date: Tue, 02 Dec 2025 16:01:35 +0000 Message-Id: <692f0d5f.3878d.278c8a27@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=44d6df4f65b1441cf9cd9f12cd41edd52205d084 commit 44d6df4f65b1441cf9cd9f12cd41edd52205d084 Author: John Baldwin AuthorDate: 2025-12-02 15:57:08 +0000 Commit: John Baldwin CommitDate: 2025-12-02 15:57:08 +0000 nvme: Use memcpy instead of memmove in nvme_cdata_get_disk_ident These buffers should not overlap. Reviewed by: imp Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D53842 --- sys/dev/nvme/nvme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme.h b/sys/dev/nvme/nvme.h index b696cc6aa697..b09fa44b0329 100644 --- a/sys/dev/nvme/nvme.h +++ b/sys/dev/nvme/nvme.h @@ -2005,7 +2005,7 @@ nvme_cdata_get_disk_ident(const struct nvme_controller_data *cdata, uint8_t *sn) _Static_assert(NVME_SERIAL_NUMBER_LENGTH < DISK_IDENT_SIZE, "NVME serial number too big for disk ident"); - memmove(sn, cdata->sn, NVME_SERIAL_NUMBER_LENGTH); + memcpy(sn, cdata->sn, NVME_SERIAL_NUMBER_LENGTH); sn[NVME_SERIAL_NUMBER_LENGTH] = '\0'; for (int i = 0; sn[i] != '\0'; i++) { if (sn[i] < 0x20 || sn[i] >= 0x80)