Date: Fri, 14 Jul 2023 13:40:16 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Danilo Egea Gondolfo <danilo@freebsd.org> Cc: ports@freebsd.org Subject: Re: graphics/xpaint updated to latest version Message-ID: <CAFDf7U%2Btd3spdfHLayDUs_KAT8gKbdDedisC7tVYLwXnopW0OQ@mail.gmail.com> In-Reply-To: <88100d98-8d22-bb31-9181-dbbfb7c1a1f4@FreeBSD.org> References: <CAFDf7U%2B%2B=-O1gY_HSbjQ9mxy%2BQWoDOD25aK4gCjEk6GgOX12cQ@mail.gmail.com> <fb6d9375-9601-e91d-ba64-a55835a9124d@FreeBSD.org> <CAFDf7UKhiUKksMRdst05yj8oCDRPawbLsBJqDUkvpxBREnTKag@mail.gmail.com> <88100d98-8d22-bb31-9181-dbbfb7c1a1f4@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000e43330060071c0b3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Oldest version used a patch:
###
--- Makefile.in.orig 2021-08-14 14:31:15 UTC
+++ Makefile.in
@@ -1203,16 +1203,15 @@ messages.h: preproc
messages.h: preproc
./preproc > messages.h
-XPaint.ad: app-defaults
- $(CC) $(CFLAGS) substads.c -o substads
- cd app-defaults ; \
+XPaint.ad: substads app-defaults
+ (cd app-defaults ; \
../substads -appdefs \
XPAINT_VERSION $(PACKAGE_VERSION) \
XPAINT_SHAREDIR $(SHAREDIR) \
XPAINT_PRINT_COMMAND "$(PRINT_CMD)" \
XPAINT_PRINTER_LIST "$(PRINTER_LIST)" \
XPAINT_POSTSCRIPT_VIEWER "$(POSTSCRIPT_VIEWER)" \
- XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)"
+ XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)")
cp -p app-defaults/out/XPaint XPaint.ad
XPaint.ad.h: substads XPaint.ad
###
that I'm not using here.
Maybe this is related? Could you test it?
Thanks
Danilo Egea Gondolfo <danilo@freebsd.org> escreveu no dia sexta, 14/07/2023
=C3=A0(s) 13:30:
> On 14/07/2023 12:42, Nuno Teixeira wrote:
>
> Hello Danilo,
>
> My tests don't show that under poudriere with ALLOW_MAKE_JOBS=3Dyes on 2
> parallel jobs.
>
> Should we wait for build packagers to see its results?
>
> Thanks,
>
> Danilo Egea Gondolfo <danilo@freebsd.org> escreveu no dia sexta,
> 14/07/2023 =C3=A0(s) 12:27:
>
>> On 14/07/2023 11:12, Nuno Teixeira wrote:
>>
>> Hello all,
>>
>> xpaint has been updated to lastest version.
>> Try out new features!
>>
>> I'm working on this update for more than 1 year but only yesterday I did
>> have the courage and nerves to build *all* releases until 3.1.4 as a way=
to
>> understand the best way to "hack" configures and Makefiles and stuff.
>>
>> Please give it a try and tell me if anything needs to be fixed, etc.
>>
>> Cheers!
>>
>>
>> https://cgit.freebsd.org/ports/commit/?id=3D973a707c70478448af77004a07ea=
b1f85c2f6757
>>
>> --
>> Nuno Teixeira
>> FreeBSD Committer (ports)
>>
>> Hi Eduardo,
>>
>> xpaint seems to not be multi-jobs-safe. The build will eventually fail
>> with this:
>> cd app-defaults ; \
>> ../substads -appdefs \
>> XPAINT_VERSION 3.1.4 \
>> XPAINT_SHAREDIR /usr/local/share/xpaint \
>> XPAINT_PRINT_COMMAND "lp -d" \
>> XPAINT_PRINTER_LIST "lpstat -p | cut -d' ' -f 2" \
>> XPAINT_POSTSCRIPT_VIEWER "evince" \
>> XPAINT_EXTERN_VIEWER "display"
>> /bin/sh: ../substads: Text file busy
>> gmake[1]: *** [Makefile:1205: XPaint.ad] Error 126
>> gmake[1]: *** Waiting for unfinished jobs....
>> gmake[1]: Leaving directory '/usr/ports/graphics/xpaint/work/xpaint-3.1.=
4'
>>
>> You might want to use MAKE_JOBS_UNSAFE=3Dyes.
>>
>>
>>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>
> That's because it's a race condition :)
>
> See:
>
> [danilo@capeta /usr/ports/graphics/xpaint]$ while : ; do make clean
> >/dev/null ; make >/dev/null 2>&1 ; if [ $? -ne 0 ] ; then echo 'Failed' =
;
> else echo 'Worked' ; fi ; done
> Worked
> Worked
> Failed
> Worked
> Worked
> Worked
> Worked
> Worked
> Worked
> Worked
> Worked
> Worked
> Failed
> Worked
> Worked
> Worked
> Worked
> Worked
> Worked
> Worked
> Failed
> Failed
> Worked
> Worked
> Worked
> Worked
> Worked
>
--=20
Nuno Teixeira
FreeBSD Committer (ports)
--000000000000e43330060071c0b3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div>Oldest version used a patch:</div><div>###<br></div><=
div>--- Makefile.in.orig =C2=A0 =C2=A02021-08-14 14:31:15 UTC<br>+++ Makefi=
le.in<br>@@ -1203,16 +1203,15 @@ messages.h: preproc<br>=C2=A0messages.h: p=
reproc<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ./preproc > messages.h<br><br>-XPa=
int.ad: app-defaults<br>- =C2=A0 =C2=A0 =C2=A0 $(CC) $(CFLAGS) substads.c -=
o substads<br>- =C2=A0 =C2=A0 =C2=A0 cd app-defaults ; \<br>+XPaint.ad: sub=
stads app-defaults<br>+ =C2=A0 =C2=A0 =C2=A0 (cd app-defaults ; \<br>=C2=A0=
=C2=A0 =C2=A0 =C2=A0 ../substads -appdefs \<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 XPAINT_VERSION $(PACKAGE_VERSION=
) \<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 XPAINT_SHAREDIR $(SHAREDIR) \<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 XPAINT_PRINT_COMMAND "$(PRINT_CMD)&quo=
t; \<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 XPAINT_PRINTER_LIST "$(PRINTER_LIST)" \<br>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 XPAINT_POSTSCRIPT_VIEW=
ER "$(POSTSCRIPT_VIEWER)" \<br>- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)=
"<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)")<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 cp -p app-defaults/out/XPaint XPaint.ad<br><br>=C2=A0XPaint.ad.h: su=
bstads XPaint.ad</div><div>###</div><div><br></div><div>that I'm not us=
ing here.</div><div>Maybe this is related? Could you test it?<br></div><div=
><br></div><div>Thanks<br></div></div><br><div class=3D"gmail_quote"><div d=
ir=3D"ltr" class=3D"gmail_attr">Danilo Egea Gondolfo <<a href=3D"mailto:=
danilo@freebsd.org">danilo@freebsd.org</a>> escreveu no dia sexta, 14/07=
/2023 =C3=A0(s) 13:30:<br></div><blockquote class=3D"gmail_quote" style=3D"=
margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-lef=
t:1ex">
=20
=20
=20
<div>
<p>On 14/07/2023 12:42, Nuno Teixeira wrote:<br>
</p>
<blockquote type=3D"cite">
=20
<div dir=3D"ltr">
<div>Hello Danilo,</div>
<div><br>
</div>
<div>My tests don't show that under poudriere with
ALLOW_MAKE_JOBS=3Dyes on 2 parallel jobs.</div>
<div><br>
</div>
<div>Should we wait for build packagers to see its results?</div>
<div><br>
</div>
<div>Thanks,</div>
</div>
<br>
<div class=3D"gmail_quote">
<div dir=3D"ltr" class=3D"gmail_attr">Danilo Egea Gondolfo <<a h=
ref=3D"mailto:danilo@freebsd.org" target=3D"_blank">danilo@freebsd.org</a>&=
gt;
escreveu no dia sexta, 14/07/2023 =C3=A0(s) 12:27:<br>
</div>
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>On 14/07/2023 11:12, Nuno Teixeira wrote:<br>
</p>
<blockquote type=3D"cite">
<div dir=3D"ltr">
<div>Hello all,</div>
<div><br>
</div>
<div>xpaint has been updated to lastest version.</div>
<div>Try out new features!</div>
<div><br>
</div>
<div>I'm working on this update for more than 1 year bu=
t
only yesterday I did have the courage and nerves to
build *all* releases until 3.1.4 as a way to
understand the best way to "hack" configures an=
d
Makefiles and stuff.</div>
<div><br>
</div>
<div>Please give it a try and tell me if anything needs
to be fixed, etc.</div>
<div><br>
</div>
<div>Cheers!</div>
<div><br>
</div>
<div><a href=3D"https://cgit.freebsd.org/ports/commit/?id=
=3D973a707c70478448af77004a07eab1f85c2f6757" target=3D"_blank">https://cgit=
.freebsd.org/ports/commit/?id=3D973a707c70478448af77004a07eab1f85c2f6757</a=
></div>
<div><br>
<span class=3D"gmail_signature_prefix">-- </span><br>
<div dir=3D"ltr" class=3D"gmail_signature">
<div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)"=
>Nuno
Teixeira<br>
FreeBSD Committer (ports)</span></div>
</div>
</div>
</div>
</blockquote>
<p>Hi Eduardo,</p>
<p>xpaint seems to not be multi-jobs-safe. The build will
eventually fail with this:<br>
</p>
cd app-defaults ; \<br>
../substads -appdefs \<br>
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 XPAINT_VERSION 3.1.4 \<br>
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 XPAINT_SHAREDIR /usr/local/share/xpaint \<br>
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 XPAINT_PRINT_COMMAND "lp -d" \<br>
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 XPAINT_PRINTER_LIST "lpstat -p | cut -d' ' -f 2"
\<br>
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 XPAINT_POSTSCRIPT_VIEWER "evince" \<br>
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 XPAINT_EXTERN_VIEWER "display"<br>
/bin/sh: ../substads: Text file busy<br>
gmake[1]: *** [Makefile:1205: XPaint.ad] Error 126<br>
gmake[1]: *** Waiting for unfinished jobs....<br>
gmake[1]: Leaving directory
'/usr/ports/graphics/xpaint/work/xpaint-3.1.4'<br>
<p>You might want to use MAKE_JOBS_UNSAFE=3Dyes.</p>
<p><br>
</p>
</div>
</blockquote>
</div>
<br clear=3D"all">
<br>
<span class=3D"gmail_signature_prefix">-- </span><br>
<div dir=3D"ltr" class=3D"gmail_signature">
<div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nuno
Teixeira<br>
FreeBSD Committer (ports)</span></div>
</div>
</blockquote>
<p>That's because it's a race condition :)</p>
<p>See:</p>
<p>[danilo@capeta /usr/ports/graphics/xpaint]$ while : ; do make
clean >/dev/null ; make >/dev/null 2>&1 ; if [ $? -ne
0 ] ; then echo 'Failed' ; else echo 'Worked' ; fi ; =
done<br>
Worked<br>
Worked<br>
Failed<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Failed<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Failed<br>
Failed<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
Worked<br>
</p>
</div>
</blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre=
fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l=
tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ=
er (ports)</span></div></div>
--000000000000e43330060071c0b3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2Btd3spdfHLayDUs_KAT8gKbdDedisC7tVYLwXnopW0OQ>