From owner-freebsd-fs@FreeBSD.ORG Fri May 25 11:42:16 2007 Return-Path: X-Original-To: freebsd-fs@freebsd.org Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E9D0B16A469 for ; Fri, 25 May 2007 11:42:16 +0000 (UTC) (envelope-from freebsd-fs@tychl.net) Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [63.240.77.83]) by mx1.freebsd.org (Postfix) with ESMTP id AB86713C45D for ; Fri, 25 May 2007 11:42:16 +0000 (UTC) (envelope-from freebsd-fs@tychl.net) Received: from masq.tychl.net (tychl.no-ip.org[67.174.137.176]) by comcast.net (sccrmhc13) with ESMTP id <2007052511421501300it724e>; Fri, 25 May 2007 11:42:15 +0000 Received: from localhost (localhost [127.0.0.1]) by masq.tychl.net (Postfix) with ESMTP id 2431B1CB4B; Fri, 25 May 2007 07:42:05 -0400 (EDT) X-Virus-Scanned: amavisd-new at tychl.net Received: from masq.tychl.net ([127.0.0.1]) by localhost (masq.tychl.net [127.0.0.1]) (amavisd-new, port 10024) with SMTP id IEQpyZT54YhP; Fri, 25 May 2007 07:42:02 -0400 (EDT) Received: from [127.0.0.1] (unknown [192.168.0.55]) by masq.tychl.net (Postfix) with ESMTP id 80FB01CB4A; Fri, 25 May 2007 07:42:02 -0400 (EDT) Message-ID: <4656CB8C.5040809@tychl.net> Date: Fri, 25 May 2007 07:42:04 -0400 From: Nick Gustas User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: "Arne \"WXrner\"" References: <452653.95653.qm@web30309.mail.mud.yahoo.com> In-Reply-To: <452653.95653.qm@web30309.mail.mud.yahoo.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org Subject: Re: Growing UFS beyond 2 TB X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2007 11:42:17 -0000 Arne WXrner wrote: > --- Nick Gustas wrote: > > >> I did a diff between the growfs.c from a 6.2-STABLE machine and what I >> have now from list patches and GCC error fixing. *WARNING* it appears >> to work, and compiles clean, but doesn't actually make a correct >> filesystem! I don't know enough C to get past this, though I suspect >> it's close and some study might get me there. >> >> http://masq.tychl.net/growfs.patch >> >> > This look wrong, too: > @@ -417,7 +417,7 @@ > acg.cg_initediblk = 0; > acg.cg_old_btotoff = start; > acg.cg_old_boff = acg.cg_old_btotoff + > - sblock.fs_old_cpg * sizeof(int32_t); > + sblock.fs_old_cpg * sizeof(int64_t); > acg.cg_iusedoff = acg.cg_old_boff + > sblock.fs_old_cpg * sizeof(u_int16_t); > } > Where have u found that? > > -Arne > > > > ____________________________________________________________________________________You snooze, you lose. Get messages ASAP with AutoCheck > in the all-new Yahoo! Mail Beta. > http://advision.webevents.yahoo.com/mailbeta/newmail_html.html > Well, originally I tried just the patches from the two messages you referred to, and it didn't work, fsck -y would scroll endlessly after the grow, and the output of growfs itself wasn't right. I figured something must still be missing, so I went at it until the compilation warnings went away, and the output looked right. However since I'm not a programmer, or UFS internals guy, I was probably a bit overzealous in my 32/64 bit searching. I figured I'd post what I had done, with a warning, in the hopes someone would correct me. Anyhow, I made the three changes you mentioned, and growfs still compiles clean, and runs with proper display, but running fsck -y on the grown file system scrolls for a long time with tons of errors and eventually bombs out asking me to run it again. running it again doesn't help. I've updated http://masq.tychl.net/growfs.patch with the changes you suggested. Keep in mind I'm no C programmer, but I can follow direction and would love to see growfs 2+TB clean :)