Date: Sun, 6 Nov 2005 22:30:22 GMT From: "Thomas E. Zander" <riggs@rrr.de> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/87853: [fix] multimedia/mplayer: no bsdbt848 driver compiled in Message-ID: <200511062230.jA6MUMrt041030@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/87853; it has been noted by GNATS.
From: "Thomas E. Zander" <riggs@rrr.de>
To: Simun Mikecin <numisemis@yahoo.com>
Cc: bug-followup@FreeBSD.org, Edwin Groothuis <edwin@FreeBSD.org>
Subject: Re: ports/87853: [fix] multimedia/mplayer: no bsdbt848 driver compiled in
Date: Sun, 6 Nov 2005 23:22:52 +0100
Hi,
Am Fri, dem 04. Nov 2005, um 7:32 -0800 Uhr schrubte Simun Mikecin
zum Thema [Re: ports/87853: [fix] multimedia/mplayer: no bsdbt848 driver compiled in]:
> It's OK with me, but maybe it would be better for
> 'configure' script to try both directories
> ('/usr/include/dev/bktr/' and '/usr/include/machine/')
> rather then doing it depending on FreeBSD version.
Well, the driver itself (libmpdemux/tvi_bsdbt848.c) does this:
#elif __FreeBSD_version >= 502100
#include <dev/bktr/ioctl_meteor.h>
#include <dev/bktr/ioctl_bt848.h>
#else
#include <machine/ioctl_meteor.h>
#include <machine/ioctl_bt848.h>
That's why I'd suggest to do it exactly like this in configure as well.
It's only a tiny change and it's consistent to how the driver handles
this.
Riggs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511062230.jA6MUMrt041030>