From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 6 22:30:23 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7841F16A41F for ; Sun, 6 Nov 2005 22:30:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 423F643D45 for ; Sun, 6 Nov 2005 22:30:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jA6MUMZw041031 for ; Sun, 6 Nov 2005 22:30:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jA6MUMrt041030; Sun, 6 Nov 2005 22:30:22 GMT (envelope-from gnats) Date: Sun, 6 Nov 2005 22:30:22 GMT Message-Id: <200511062230.jA6MUMrt041030@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: "Thomas E. Zander" Cc: Subject: Re: ports/87853: [fix] multimedia/mplayer: no bsdbt848 driver compiled in X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Thomas E. Zander" List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Nov 2005 22:30:23 -0000 The following reply was made to PR ports/87853; it has been noted by GNATS. From: "Thomas E. Zander" To: Simun Mikecin Cc: bug-followup@FreeBSD.org, Edwin Groothuis Subject: Re: ports/87853: [fix] multimedia/mplayer: no bsdbt848 driver compiled in Date: Sun, 6 Nov 2005 23:22:52 +0100 Hi, Am Fri, dem 04. Nov 2005, um 7:32 -0800 Uhr schrubte Simun Mikecin zum Thema [Re: ports/87853: [fix] multimedia/mplayer: no bsdbt848 driver compiled in]: > It's OK with me, but maybe it would be better for > 'configure' script to try both directories > ('/usr/include/dev/bktr/' and '/usr/include/machine/') > rather then doing it depending on FreeBSD version. Well, the driver itself (libmpdemux/tvi_bsdbt848.c) does this: #elif __FreeBSD_version >= 502100 #include #include #else #include #include That's why I'd suggest to do it exactly like this in configure as well. It's only a tiny change and it's consistent to how the driver handles this. Riggs