From owner-svn-src-head@FreeBSD.ORG Tue Nov 27 15:08:39 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3431D6F7; Tue, 27 Nov 2012 15:08:39 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 8F3A08FC16; Tue, 27 Nov 2012 15:08:38 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qARF8VVN077155; Tue, 27 Nov 2012 17:08:31 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.1 kib.kiev.ua qARF8VVN077155 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qARF8V75077154; Tue, 27 Nov 2012 17:08:31 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 27 Nov 2012 17:08:31 +0200 From: Konstantin Belousov To: Andriy Gapon Subject: Re: svn commit: r243599 - head/sys/kern Message-ID: <20121127150831.GK3013@kib.kiev.ua> References: <201211270607.qAR67w6O094153@svn.freebsd.org> <50B48EE9.1090506@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sCNd3Ivk/oijKKf1" Content-Disposition: inline In-Reply-To: <50B48EE9.1090506@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, David Xu X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2012 15:08:39 -0000 --sCNd3Ivk/oijKKf1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2012 at 11:59:05AM +0200, Andriy Gapon wrote: > on 27/11/2012 08:07 David Xu said the following: > > Author: davidxu > > Date: Tue Nov 27 06:07:58 2012 > > New Revision: 243599 > > URL: http://svnweb.freebsd.org/changeset/base/243599 > >=20 > > Log: > > Take first active vnode correctly. > > =20 > > Reviewed by: kib > > MFC after: 3 days > >=20 > > Modified: > > head/sys/kern/vfs_subr.c > >=20 > > Modified: head/sys/kern/vfs_subr.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/kern/vfs_subr.c Tue Nov 27 06:01:02 2012 (r243598) > > +++ head/sys/kern/vfs_subr.c Tue Nov 27 06:07:58 2012 (r243599) > > @@ -4755,7 +4755,7 @@ __mnt_vnode_first_active(struct vnode ** > > MNT_REF(mp); > > (*mvp)->v_type =3D VMARKER; > > =20 > > - vp =3D TAILQ_NEXT(*mvp, v_actfreelist); > > + vp =3D TAILQ_FIRST(&mp->mnt_activevnodelist); > > while (vp !=3D NULL) { > > VI_LOCK(vp); > > if (vp->v_mount =3D=3D mp && vp->v_type !=3D VMARKER && > >=20 >=20 > Oh, wow, did this even work before? > Did it always just return NULL and no active list iteration happened? Yes. Due to some redundancy in the VFS, the consequences were much less fatal than it could be. --sCNd3Ivk/oijKKf1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlC0124ACgkQC3+MBN1Mb4gGvQCfTPP6l/tIlnZiC7jh8URJEART CT4AoImg06M5EDKf960V1RC0gfiQWiNZ =Oqaj -----END PGP SIGNATURE----- --sCNd3Ivk/oijKKf1--