From owner-cvs-all Sun May 9 16: 4:37 1999 Delivered-To: cvs-all@freebsd.org Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (Postfix) with ESMTP id A041E14EE2; Sun, 9 May 1999 16:04:30 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id IAA14476; Mon, 10 May 1999 08:34:30 +0930 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id IAA38597; Mon, 10 May 1999 08:34:29 +0930 (CST) Date: Mon, 10 May 1999 08:34:28 +0930 From: Greg Lehey To: Bruce Evans Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, phk@FreeBSD.org Subject: Re: cvs commit: src/sys/sys types.h Message-ID: <19990510083428.K22791@freebie.lemis.com> References: <199905092221.IAA25882@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: <199905092221.IAA25882@godzilla.zeta.org.au>; from Bruce Evans on Mon, May 10, 1999 at 08:21:50AM +1000 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Monday, 10 May 1999 at 8:21:50 +1000, Bruce Evans wrote: >> Modified files: >> sys/sys types.h >> Log: >> Make minor, major and makedev inline functions so we gain type checking >> and prevent compile time creation of dev_t's from happening again. > > You can't do that. It adds gratuitous dependencies on the compiler being > gcc to the most central header in the system. Well, the dependency is on a compiler that understands `inline'. Are we planning to migrate to one that doesn't in the near future? It also allows more type checking than a macro. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message