From owner-svn-src-all@freebsd.org Fri Aug 17 10:26:08 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F18E105578A; Fri, 17 Aug 2018 10:26:08 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0AAF76628; Fri, 17 Aug 2018 10:26:07 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-wm0-f49.google.com with SMTP id s9-v6so7120367wmh.3; Fri, 17 Aug 2018 03:26:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T6E98hZdunJSeeK1/B6GZw8zY6hf7zrO7pU/iPRFNYo=; b=QRb103owd5rSL4GM8cRD10bkofIMweRLPu106fjx1t4IBeNlK0qRG9hGwhbThz0Qjo GtCnkmJyNci5co3pluLN7vA6EzSKUotrNrC1zqZRp4txk6uiMZxL0J/NfBcJsezYtCMk nrB9QGmGQmXy9domkgH66oUbFPCy4C4jsa1URz0kZ9RxMi4kEEzLm9UvsxKuw1UWhLZV 5bFUVZd6RfKeLu/JzKxz78LijCApw9psrqfpWRjh9TGra8STICgGAgahSWOGZBC1pvlg SvgWdhwfsfl+rInD8ofYnYchVHaLJHCrZreK+JbBNl08DpthXdnq5u6A8PWPUx2MgHM1 ytwg== X-Gm-Message-State: AOUpUlEXatGlBBdUTwi/zq8feFpOxtIka2QUBKV5bVtBFU3Xr2s2jB9G OjTPhWTPhWXK4efHBGG5I1Zm81EZO/mrC8MnnYDp4I7A X-Google-Smtp-Source: AA+uWPyIycvDe/It8DjeCyJZgFGNDkf6dvUAmWEeMP7ZPt/fHhR91oJmwgI9NpOVDGA3OdGxQ9Xz8RmpHDMdH2qztbo= X-Received: by 2002:a1c:13ca:: with SMTP id 193-v6mr17636921wmt.127.1534501560628; Fri, 17 Aug 2018 03:26:00 -0700 (PDT) MIME-Version: 1.0 References: <201808170023.w7H0Np0H027296@repo.freebsd.org> <3ffeebe7-07c5-bab2-d8c6-45d48adf662f@FreeBSD.org> In-Reply-To: <3ffeebe7-07c5-bab2-d8c6-45d48adf662f@FreeBSD.org> From: Li-Wen Hsu Date: Fri, 17 Aug 2018 11:25:48 +0100 Message-ID: Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... To: John Baldwin Cc: Conrad Meyer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 10:26:08 -0000 On Fri, Aug 17, 2018 at 7:26 AM John Baldwin wrote: > > On 8/17/18 1:23 AM, Conrad Meyer wrote: > > Author: cem > > Date: Fri Aug 17 00:23:50 2018 > > New Revision: 337936 > > URL: https://svnweb.freebsd.org/changeset/base/337936 > > > > Log: > > Bring in libsodium to sys/contrib > > > > Bring in https://github.com/jedisct1/libsodium at > > 461ac93b260b91db8ad957f5a576860e3e9c88a1 (August 7, 2018), unmodified. > > > > libsodium is derived from Daniel J. Bernstein et al.'s 2011 NaCl > > ("Networking and Cryptography Library," pronounced "salt") software library. > > At the risk of oversimplifying, libsodium primarily exists to make it easier > > to use NaCl. NaCl and libsodium provide high quality implementations of a > > number of useful cryptographic concepts (as well as the underlying > > primitics) seeing some adoption in newer network protocols. > > > > I considered but dismissed cleaning up the directory hierarchy and > > discarding artifacts of other build systems in favor of remaining close to > > upstream (and easing future updates). > > > > Nothing is integrated into the build system yet, so in that sense, no > > functional change. > > Can you import this into the vendor area and then do a bootstrap of > mergeinfo to sys/contrib? This permits future updates to use svn to > merge instead of doing it by hand. It also permits future imports to > be done by other developers following our standard, documented process > for working with third-party code. There are some files like `builds/msvc/*` probably not very useful for FreeBSD. I might be good to have these files listed in FREEBSD-Xlist and excluded from importing. Best, Li-Wen -- Li-Wen Hsu https://lwhsu.org