From owner-p4-projects@FreeBSD.ORG  Sun Feb 20 21:46:59 2011
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2B6B71065673; Sun, 20 Feb 2011 21:46:59 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E235B1065670
	for <perforce@freebsd.org>; Sun, 20 Feb 2011 21:46:58 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id CDAF38FC23
	for <perforce@freebsd.org>; Sun, 20 Feb 2011 21:46:58 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id p1KLkwBJ098178
	for <perforce@freebsd.org>; Sun, 20 Feb 2011 21:46:58 GMT
	(envelope-from trasz@freebsd.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id p1KLkw82098175
	for perforce@freebsd.org; Sun, 20 Feb 2011 21:46:58 GMT
	(envelope-from trasz@freebsd.org)
Date: Sun, 20 Feb 2011 21:46:58 GMT
Message-Id: <201102202146.p1KLkw82098175@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	trasz@freebsd.org using -f
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 188985 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Feb 2011 21:46:59 -0000

http://p4web.freebsd.org/@@188985?ac=10

Change 188985 by trasz@trasz_victim on 2011/02/20 21:46:46

	Loginclass name must not be empty.

Affected files ...

.. //depot/projects/soc2009/trasz_limits/sys/kern/kern_loginclass.c#31 edit

Differences ...

==== //depot/projects/soc2009/trasz_limits/sys/kern/kern_loginclass.c#31 (text+ko) ====

@@ -113,7 +113,7 @@
 {
 	struct loginclass *lc, *newlc;
 
-	if (strlen(name) > MAXLOGNAME - 1)
+	if (name[0] == '\0' || strlen(name) > MAXLOGNAME - 1)
 		return (NULL);
 
 	newlc = malloc(sizeof(*newlc), M_LOGINCLASS, M_ZERO | M_WAITOK);
@@ -198,9 +198,10 @@
 	if (error != 0)
 		return (error);
 
+	newlc = loginclass_find(lcname);
+	if (newlc == NULL)
+		return (EINVAL);
 	newcred = crget();
-	newlc = loginclass_find(lcname);
-	KASSERT(newlc != NULL, ("loginclass_find() failed"));
 
 	PROC_LOCK(p);
 	oldcred = crcopysafe(p, newcred);