From owner-cvs-src Wed Mar 19 21: 7:23 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 415FB37B405; Wed, 19 Mar 2003 21:07:20 -0800 (PST) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAE6543F3F; Wed, 19 Mar 2003 21:07:17 -0800 (PST) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.8/8.12.8) with ESMTP id h2K57Fjx048241; Thu, 20 Mar 2003 08:07:16 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.8/8.12.6/Submit) id h2K57Faw048240; Thu, 20 Mar 2003 08:07:15 +0300 (MSK) (envelope-from ache) Date: Thu, 20 Mar 2003 08:07:13 +0300 From: "Andrey A. Chernov" To: David Schultz Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gdtoa gdtoaimp.h Message-ID: <20030320050712.GA48184@nagual.pp.ru> References: <200303192025.h2JKPjNr000550@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200303192025.h2JKPjNr000550@repoman.freebsd.org> User-Agent: Mutt/1.5.1i Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Mar 19, 2003 at 12:25:45 -0800, David Schultz wrote: > Log: > Enable locale support in strtod() and dtoa(). > > Noticed by: ache > Reviewed by: mike (mentor) It seems that locale implementation is not complete - see gethex.c:gethex() '.' processing (must be actual decimal point here). The fix is obvious (like in other places). The next thing is style: why #include "locale.h" instead of #include ? -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message