From owner-svn-src-head@FreeBSD.ORG Wed Sep 26 01:40:05 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5442D1065674; Wed, 26 Sep 2012 01:40:05 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) by mx1.freebsd.org (Postfix) with ESMTP id EBD948FC17; Wed, 26 Sep 2012 01:40:04 +0000 (UTC) Received: by ieak10 with SMTP id k10so264584iea.13 for ; Tue, 25 Sep 2012 18:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=jkcTIW+fEZXuEzzZDi92Qytm68yGiXp4SXH9zOd9sjI=; b=RvzSfOfyK0oUPWBC8Wo3uq547hK5jXPMIn0ctCjfq+Y+3zRu3v+0efsdRedwjpc6/P 5U7wSV9f5zpKtdsNS6MVoatGWg64Y7CgQEWyGrMTe8hyUYQHgd11vXRJlHz0WTpLEU9l htQp1Yoo8DPFYnK0tSIYlyR6DOP3FJyR5CMP+Q/zpJOezpaWZxEFg9+GPZE72K+FTEfo InuHkEeEQqONJA5QUriQqSEl9Zb6N16iOEqyMznTbqR41fsrdwULnglTt+QAXQfZlU5T U5bjSzsiiUQgF0XgP6xn2TkN2U+0dvXBfakIwJBtzdkG8C2dnczhu5rpy2krCpewUeNN d1pA== MIME-Version: 1.0 Received: by 10.50.47.234 with SMTP id g10mr9801232ign.16.1348623603531; Tue, 25 Sep 2012 18:40:03 -0700 (PDT) Sender: carpeddiem@gmail.com Received: by 10.50.57.163 with HTTP; Tue, 25 Sep 2012 18:40:03 -0700 (PDT) In-Reply-To: References: <201209260025.q8Q0PAp0021186@svn.freebsd.org> Date: Tue, 25 Sep 2012 21:40:03 -0400 X-Google-Sender-Auth: 95LW8nrDqus_jIIyotfvW6UYE5o Message-ID: From: Ed Maste To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240944 - in head/tools/regression/net: . if_tap X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2012 01:40:05 -0000 On 25 September 2012 21:11, Garrett Cooper wrote: > On Tue, Sep 25, 2012 at 5:25 PM, Ed Maste wrote: >> Author: emaste >> Date: Wed Sep 26 00:25:09 2012 >> New Revision: 240944 >> URL: http://svn.freebsd.org/changeset/base/240944 ... > This test is technically only valid if sysctl > kern.features.invariant_support == 1, right? It's only possible to prove that the bug described in kern/172075 is fixed if kern.features.invariant_support == 1, yes. Without invariants though the test still verifies that a tap(4) device can be properly destroyed when open and not. I have another change coming that will cause cat(1) to terminate immediately when the device is destroyed, and this script will become a valid test of that behaviour with or without INVARIANTS. Ideally the script would report pass or fail for the individual tap(4) create and destroy invocations, and separately pass or unsupported for kern/172075 based on kern.features.invariant_support. I'd like to figure out how to implement that once our test framework is in place. -Ed