From owner-freebsd-current Mon Jan 18 17:26:40 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA17215 for freebsd-current-outgoing; Mon, 18 Jan 1999 17:26:40 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from janus.syracuse.net (janus.syracuse.net [205.232.47.15]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA17206 for ; Mon, 18 Jan 1999 17:26:37 -0800 (PST) (envelope-from green@unixhelp.org) Received: from localhost (green@localhost) by janus.syracuse.net (8.8.8/8.8.7) with ESMTP id UAA06184; Mon, 18 Jan 1999 20:26:18 -0500 (EST) Date: Mon, 18 Jan 1999 20:26:18 -0500 (EST) From: Brian Feldman X-Sender: green@janus.syracuse.net To: Bruce Evans cc: mike@smith.net.au, current@FreeBSD.ORG, dillon@apollo.backplane.com, julian@whistle.com Subject: Re: kernel malloc and M_CANWAIT In-Reply-To: <199901182221.JAA18722@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 19 Jan 1999, Bruce Evans wrote: > >Look at the void () functions that call malloc/MALLOC. Also, commit the > >attached patch; it was OKed by Bruce to disallow this, but he seems to forget > >to commit it. > > It is queued behind 10-100 other patches. > > >--- src/sys/kern/vfs_syscalls.c.orig Fri Dec 25 22:27:21 1998 > >+++ src/sys/kern/vfs_syscalls.c Fri Dec 25 22:28:12 1998 > >@@ -2909,6 +2909,10 @@ > > if (error = namei(&nd)) > > return (error); > > vp = nd.ni_vp; > >+ if (vp->v_type == VFIFO) { > >+ error = EINVAL; > >+ goto out; > >+ } > > if (error = VOP_GETATTR(vp, &vattr, p->p_ucred, p)) > > goto out; > > if (p->p_ucred->cr_uid != vattr.va_uid && > > Actually, the patch from Lite1 is queued. It also backs out support > for revoke of everything except cdevs and bdevs. I don't have time to > check what happens for regular files, pipes and sockets... Hmm... that may be a good idea, although for it seems to work on all of them, I haven't checked for any kind of leak in the others, nor would truly expect one. And pipes ARE fifo's aren't they? > > Bruce > Brian Feldman _ __ ___ ___ ___ green@unixhelp.org _ __ ___ | _ ) __| \ http://www.freebsd.org/ _ __ ___ ____ | _ \__ \ |) | FreeBSD: The Power to Serve! _ __ ___ ____ _____ |___/___/___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message