From nobody Mon Jul 6 15:49:14 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gv8170Y8jz6kGNX for ; Mon, 06 Jul 2026 15:49:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gv81673KXz3Jfc for ; Mon, 06 Jul 2026 15:49:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783352955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XsV557oWtWner70wosh1lacfptKqH6VuLVZrVPb3ZnI=; b=Vl09utqopsI1ZRrW+vjmAudbjnuk50HpWzpQKyS0kN/LonPVoXAHQOfXUEmpOzGGb2o3EB uVnwllzafdJOHN0iqY8VrkNJolq7iDd05e6zFufxdkr1tbu0Z7xiz6gmB0pIQ2UULf2wwT wnPvVz6ykOupsaoWkfOpswZ3FqpZ7D876BkAx3M+CbhRq/liyRoIFzZr0FKs5afQcKybXt jJ1GHLEeM2Whu27MXU0DfNG9HARgHrfEcrOQWB8VrXTX7W4ZZ4TDyhVDgOP8H0suzL+GC+ 02F2SB88PJ+92XApDflXMIAKspKzz3jxeBCwG9ZALcD3nUES8cWt7adA+qUTFQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783352955; a=rsa-sha256; cv=none; b=CdUTx6AJXVoXeC395jv75SrroKS9aauE9hWZ6wpgAgfnog6+J/MjsMDbZIvpd8/scm4n7J tTsie4LJi/Lnk8wVeZjMWuwYKYPcop377j4tLAaf8E92LIccR08FERPmuR3cmbZSJQ8ywU 0lvUU6Mj/FFronWR9IzL51ZTNJZKXzPqAlGSYzXH4dWtuzmE9brJVS0dNmWa4/oB9VVCB3 tK+b0e5PuYCmrmhA/d2gMjpus2lFtAPuEQZoTWgvonmw+fllRYwboID3seHdViUFovJkpa p7pPEEleHS4G9HhW76NjN3W1EpUVfBD/hTWbQPZYRz6tZNf3OHpNwq6q3R1rSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783352955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XsV557oWtWner70wosh1lacfptKqH6VuLVZrVPb3ZnI=; b=HiVnOwueqiath+AZ8LCMBhK6u5EqnIKt9vim9HMtZH3s9ElQc0EUbF5oHAg1qArWQye7Bu SanKswSMBTVhILYhVtSAF4vjz99gwj55f/kX5j6Q1VbTjs0kIBNrq8MXQ2UFvvUTysUpk7 dJ5mrMxWoVHBEl1kzJt3WQ0Hopc6DINpEvZxmJqIVYs81T7IGU6fhun8ShOTvVWykbGy5D C4B51SIBtDDIOse/w1UmA/ZCYeh0X5iQAfg3KmW/NwzxITBYvc5QnRXrigE8R5EloU+gIW wVFtoYczBIIjbfRG3I7JBpvp9ou0wWt73cdqLaZWI4rZihB9VLL56v8brgX4EQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gv8165Z24z19WM for ; Mon, 06 Jul 2026 15:49:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1eece by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 06 Jul 2026 15:49:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 58c73727d6e4 - main - vfs: Fix resource leaks in kern_symlinkat() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 58c73727d6e49de1fc4f4bc90621146cae8db2bc Auto-Submitted: auto-generated Date: Mon, 06 Jul 2026 15:49:14 +0000 Message-Id: <6a4bce7a.1eece.18e1b08e@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=58c73727d6e49de1fc4f4bc90621146cae8db2bc commit 58c73727d6e49de1fc4f4bc90621146cae8db2bc Author: Mark Johnston AuthorDate: 2026-07-06 15:42:52 +0000 Commit: Mark Johnston CommitDate: 2026-07-06 15:46:01 +0000 vfs: Fix resource leaks in kern_symlinkat() Fixes: 2ec2ba7e232d ("vfs: Add VFS/syscall support for Solaris style extended attributes") Reported by: Yuxiang Yang, Yizhou Zhao, Ao Wang, Xuewei Feng, Qi Li, and Ke Xu from Tsinghua University using GLM-5.2 from Z.ai Reviewed by: rmacklem, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58053 --- sys/kern/vfs_syscalls.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index ec952cac1d2e..59d0c9c40927 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -1882,7 +1882,7 @@ restart: } if ((vn_irflag_read(nd.ni_dvp) & VIRF_NAMEDDIR) != 0) { error = EINVAL; - goto out; + goto out2; } VATTR_NULL(&vattr); vattr.va_mode = ACCESSPERMS &~ td->td_proc->p_pd->pd_cmask; @@ -1894,9 +1894,7 @@ restart: goto out2; #endif error = VOP_SYMLINK(nd.ni_dvp, &nd.ni_vp, &nd.ni_cnd, &vattr, syspath); -#ifdef MAC out2: -#endif VOP_VPUT_PAIR(nd.ni_dvp, error == 0 ? &nd.ni_vp : NULL, true); vn_finished_write(mp); NDFREE_PNBUF(&nd);