From owner-svn-ports-all@freebsd.org  Sat Dec 22 17:05:16 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F6E51358B10;
 Sat, 22 Dec 2018 17:05:16 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id DA3C18F4E5;
 Sat, 22 Dec 2018 17:05:15 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id CBCDF1ACED; Sat, 22 Dec 2018 17:05:15 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Mark Linimon <linimon@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r488033 - head/science/InsightToolkit/files
References: <201812220052.wBM0qV0S051606@repo.freebsd.org>
Date: Sat, 22 Dec 2018 18:05:10 +0100
In-Reply-To: <201812220052.wBM0qV0S051606@repo.freebsd.org> (Mark Linimon's
 message of "Sat, 22 Dec 2018 00:52:31 +0000 (UTC)")
Message-ID: <8t0h-1ohl-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: DA3C18F4E5
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.91 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.99)[-0.993,0];
 NEURAL_HAM_SHORT(-0.92)[-0.922,0];
 NEURAL_HAM_LONG(-0.99)[-0.990,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Dec 2018 17:05:16 -0000

Mark Linimon <linimon@FreeBSD.org> writes:

> Author: linimon
> Date: Sat Dec 22 00:52:31 2018
> New Revision: 488033
> URL: https://svnweb.freebsd.org/changeset/ports/488033
>
> Log:
>   This port currently doesn't build on GCC-based architectures, due to
>   not supporting GCC8.  Make GCC8 use the same macros as the newest
>   supported version, GCC 7.3.
[...]
> +@@ -86,6 +86,9 @@
> + #  else
> + #   define VCL_GCC_70
> + #  endif
> ++#  elif (__GNUC__==8)
> ++#   define VCL_GCC_7
> ++#   define VCL_GCC_73
> + # else
> + #  error "Dunno about this gcc"
> + # endif

Confusing indentation. #elif after #endif would be a syntax error but
(__GNUC__==8) isn't actually under (__GNUC__==7) branch.

Can you shift the new lines left by one space?