From owner-freebsd-current@FreeBSD.ORG Thu Oct 9 15:18:19 2014 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DD12FC58 for ; Thu, 9 Oct 2014 15:18:19 +0000 (UTC) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE23CC9B for ; Thu, 9 Oct 2014 15:18:19 +0000 (UTC) Received: from [192.168.200.200] (unknown [50.136.155.142]) (using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id BC6A71928D6; Thu, 9 Oct 2014 15:18:12 +0000 (UTC) Subject: Re: Floating-point review From: Sean Bruno Reply-To: sbruno@freebsd.org To: Andrew Turner In-Reply-To: <20141008131440.41b12409@bender.lan> References: <20141008131440.41b12409@bender.lan> Content-Type: text/plain; charset="us-ascii" Date: Thu, 09 Oct 2014 08:18:10 -0700 Message-ID: <1412867890.1133.2.camel@bruno> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 15:18:19 -0000 On Wed, 2014-10-08 at 13:14 +0100, Andrew Turner wrote: > I'm looking for someone who known more about floating-point than I do > to review one of me changes. The change in question adds 6 new > functions to the ARM libc to perform floating-point comparisons. These > functions are required as part of the ABI spec. > > The review is at [1]. I am mostly interested in having someone check > __aeabi_cfcmpeq_helper and __aeabi_cdcmpeq_helper are correct. They > should both return when either argument is a quiet NaN unless one is a > signalling NaN for floats and doubles respectively. > > These functions are used by a functions that is defined to not raise a > floating point exception with comparing with quiet NaNs and all > comparisons with signalling NaNs could potentially raise an exception. > Because of this requirement these functions are used to filter out the > cases we have one or more quiet NaNs and no signalling NaNs. > > Andrew > > [1] https://reviews.freebsd.org/D872 Andrew knows this, but I'll drop it here for the rest of you folks. I've applied this patch and am seeing very good *compile* results from my ports build science. I might actually break 20k ports built this run. Please get folks who know compilers and C to look at this. From my very primitive eye it *seems* correct. http://chips.ysv.freebsd.org/build.html?mastername=11armv6-default&build=2014-10-05_21h42m23s sean