From owner-freebsd-questions@freebsd.org Fri Apr 17 16:06:03 2020 Return-Path: Delivered-To: freebsd-questions@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8ED132BEF67 for ; Fri, 17 Apr 2020 16:06:03 +0000 (UTC) (envelope-from pawel@jasiak.xyz) Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 493gtf2802z49p4 for ; Fri, 17 Apr 2020 16:06:02 +0000 (UTC) (envelope-from pawel@jasiak.xyz) Received: by mail-lj1-x22c.google.com with SMTP id z26so2551409ljz.11 for ; Fri, 17 Apr 2020 09:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jasiak-xyz.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-disposition; bh=0XhEUTJUZd3BNTEYJ4LaE3ZTNYYCgWLisbASOmPw+Qk=; b=ELpHbMgq/kBAwUZRgQ2wUkLDR5ogCTRPK5apVTRN2M+QgujdlT3oRHhAAkAvNXiUa+ 6tSS3L1IZ1l6LN2SB0I66HbHbHJVYwnuSym4ylGeNV/6N/3SfU0p8I621C6IWXk/Zsfe CYTZ94LwDd+81sJU9kVeXXliwWuJ92sWWRELBWbEBhIVLHdXjlRJacXP4RAigcBARV5N NraAXxzjXIszotbbT/yVHc1LXm97z9ua7ZVqLRLszVVXfgGKRWwZsWM3cV8dn8HM2KEE 2ozY7o4xV1Ir/teK8hTgd3sK+9HVBhDS8rbKBtmcftGctTtoW1cZWn+0Dfm+JNNSj5WC XnHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=0XhEUTJUZd3BNTEYJ4LaE3ZTNYYCgWLisbASOmPw+Qk=; b=Ml31A8UMt8qidCVLiB16VGjUkVK8gJDc/Q+W4ljf1/JE0hAtKfK2JZhDYHCj8lH17k EaFY0B9bi0yywCrLYTzUExOH3W9V+fkFvoUDL2TX0qVVxDUltAnhoejec0awbFlbLWFZ r7t2pfnvi6kkpIrZrcQqAw0uZZFm2Kd5VLiZgwDPYa1/GThzqXyHCiu2+sGOWzTEaEgf 3LL/K4Dl9Mb8mF0uKmNV8srj9r7vCdJuer+R5gbPJegEl6W8WVHkYqwaHLL7JMDxBn3N aefva4FDLmylpdDb5lnTK8tIcCiae2PxYNaAyOLtk9leQcBJZ3FA9OeAjPrI/ei2SM9Y FBUw== X-Gm-Message-State: AGi0PubdUBIWpgh32zIyXSHNgX+S9hOwu2tkP5VbyPc+8y6m4BlBJ+cV DaSuMuBJby4niyggM78OZdQkuLEr+lg= X-Google-Smtp-Source: APiQypLQgX7RikxEYEurkHnjnnP4f+EcLyJM/VsVNnOGs1Tcti4fiaFjucpLefLqDQqLW+J2m4dO9A== X-Received: by 2002:a2e:a584:: with SMTP id m4mr2613116ljp.194.1587139559400; Fri, 17 Apr 2020 09:05:59 -0700 (PDT) Received: from gmail.com (wireless-nat-78.ip4.greenlan.pl. [185.56.211.78]) by smtp.gmail.com with ESMTPSA id a10sm11959078ljp.16.2020.04.17.09.05.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 09:05:58 -0700 (PDT) Date: Fri, 17 Apr 2020 18:05:56 +0200 From: =?utf-8?B?UGF3ZcWC?= Jasiak To: freebsd-questions@freebsd.org Subject: Arguments format Message-ID: <20200417160556.GA44862@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline X-Rspamd-Queue-Id: 493gtf2802z49p4 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=jasiak-xyz.20150623.gappssmtp.com header.s=20150623 header.b=ELpHbMgq; dmarc=none; spf=pass (mx1.freebsd.org: domain of pawel@jasiak.xyz designates 2a00:1450:4864:20::22c as permitted sender) smtp.mailfrom=pawel@jasiak.xyz X-Spamd-Result: default: False [-1.53 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(0.00)[jasiak-xyz.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip6:2a00:1450:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-questions@freebsd.org]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_XBL(5.00)[78.211.56.185.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.4]; RCPT_COUNT_ONE(0.00)[1]; BAD_REP_POLICIES(0.10)[]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[jasiak.xyz]; DKIM_TRACE(0.00)[jasiak-xyz.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[c.2.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.43)[ip: (-9.35), ipnet: 2a00:1450::/32(-2.35), asn: 15169(-0.43), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[78.211.56.185.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2020 16:06:03 -0000 --azLHFNyN32YCQGCU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! I have three questions. 1. In sys/mips/mips/autoconf.c we have functions static void configure_first(dummy) static void configure(dummy) static void configure_final(dummy) and we are not using argument. We are having those functions also in ricv, arm, arm64, powerpc and x86 and in non of them we are using dummy, so maybe we can just remove it? Or if it is necessary why we don't mark it as __unused like in other functions? 2. Above functions have strange definition for arguments. static void configure(dummy) void *dummy; { ... } Why we are not using static void configure(void *dummy) { ... } like in other places? 3. In sys/mips/mips/octeon_cop2.c we are having struct octeon_cop2_state * octeon_cop2_alloc_ctx() { ... } but it's declaration in sys/mips/include/octeon_cop2.h is struct octeon_cop2_state* octeon_cop2_alloc_ctx(void); Question is if we should change octeon_cop2_alloc_ctx() into octeon_cop2_alloc_ctx(void)? I will be happy to help with creating patches. Thanks! --=20 Pawe=C5=82 Jasiak --azLHFNyN32YCQGCU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEENIqkLxDcCMlLMdi0FzfmQudzVTgFAl6Z0+QACgkQFzfmQudz VThppw/+ObyczsMDZR1w4C2suW3qysvt0oiiVk0tSNvssaa1AAKzoZZBG9wFt4z4 BIdKjdEKQCrUjHvMRM62eJQArfrvyqPrxzZW++D72FeacvBZQzM4wyGcmifKVbip yySvz4H060YSuYNMPqDWr4MOE+7w7VjY+FkDvoKP9p0d1X8kuGRCZktxuzrO/f5e iEvKHhlXYNiwHoSBbUepR/uu7/mBJrYvvJ7R82VPnW6Yow77yFbQzCheDCV5Hkax sMCa1u5aEW6ueXypZ+g6F7zHm6IhJ0mHuPVDFf9cW8VXF2AMzokJe5Tspf2fuFdu TQG/rYJgJtJMF3CKYyCm0TZZq3rH9oOysD5mSKEPEd6uLRYnRf46/53bCtD8O/Ga s8uVs7b984lD+SLMcQ6Qv9yhkxDERi9T0n8nGX8UlGlR8UeJXeijodqEeja85kGk OTWTMboAs87YADmnU/ZRY+m0fTpiHL+2OVr8xbnXIDGWUcIghnYAn4RP8f1HsCUB vJL4p/VIEDNWwmvVLXMBv31mz9roifes+vl43bTla+IzzzH19LwsdWcoDyHhjhrL 6hhzYfGjIFJswfmfI1MObQpwP1DjCEl6zW8nvtCZUg8eTvezgxlf1q3RIB4L/cDz GTwX/ZhgsxiHkZ0gcPM8AyungZPy3GHGbCvgAT7TWxfd0XN19Y0= =H3Ge -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--