Date: Wed, 19 Sep 2001 12:46:49 -0700 From: "David O'Brien" <obrien@FreeBSD.ORG> To: "Andrew M. Miklic" <miklic@attglobal.net> Cc: freebsd-alpha@FreeBSD.ORG Subject: Re: TGA driver Message-ID: <20010919124649.A29411@dragon.nuxi.com> In-Reply-To: <3BA8C3A0.3070709@attglobal.net>; from miklic@attglobal.net on Wed, Sep 19, 2001 at 10:11:12AM -0600 References: <3BA8C3A0.3070709@attglobal.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 19, 2001 at 10:11:12AM -0600, Andrew M. Miklic wrote:
> I have tried unsuccessfuly to get it committed by various people
I have sent you feedback on the files (Date: Tue, 11 Sep 2001 22:19:14
-0700). Did you not get my email?
Please go over the TGA files and remove all the embedded comments
that remove code. They should be properly wrapped in #if 0 / #endif
pairs. Also please read style(9). Functions too long to be fit on
one line are indented by 4 spaces, not lined up with the `('. I am
also converting this to ANSI function definitions.
I included my versions of your files (I spent 3 hrs cleaning them up) so
you could diff them with what you have to see the needed changes and
finish them.
--
-- David (obrien@FreeBSD.org)
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010919124649.A29411>