From nobody Thu Mar 2 13:34:22 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PSBsl4GMQz3vqPF; Thu, 2 Mar 2023 13:34:35 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PSBsl3Z9Tz4DNM; Thu, 2 Mar 2023 13:34:35 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677764075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NBdgANEyV3VdkI1jVG3YkY2vwtutbx+l9rYvoQx7sJw=; b=oAvWCX/KqoPNqJgw7EM+qsY/mrp+CA4/xIXvttg8g3VH448JbCKYsJePvzJMvhCs5H8P9b dRGf3h8q/vv8ZFPs+i05GkE35jgULGpD/fAtKLoWAMTrK3Bw/aL4An+LrY2IgcQeETQB94 QTYk1M5JV4xukm4Rq6Klpisw+hKrmfX3Scw5sghCxUUHYSV5BoVdXT/vaY2V9SXfWYErKC QMu977CXH5LYrEOyvzbluV/gMHdhfEh6R+21qqZbJ1+xFPF9vrE+rT8D0VNxEHxlx/X8jc SbuPwnkviYUArML9OPZmqczzrDetAwiZRdWJ2VsaBPW8GJFuXDfkLxJHkpTiXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677764075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NBdgANEyV3VdkI1jVG3YkY2vwtutbx+l9rYvoQx7sJw=; b=sK62cWsoGFTA53f5NGv8BQIchGSiOVcHQmqa12l7vW26jbpWjEp2Y8y/zfXS9A17VxeVTW uQlGxZacKNlhvMgfx3nbqV+DtdAwtW1lsknaqV4u7kUYONjqGGqTrbW+5+sBfjPEDESYVv BViP3e8HFpqjQl4cwVJYgCGY0hRhJdleOBw6NvsK9jvchdRgJYNRHRHyblh0tKm/Ip7Jfo J9Z+iIabpnW6l7i2BHt/ou1U0w8eglBuxfUNImeXtQKMtdrxbNEU0VgKf9nvHsPvaen9Wa s2Ehsh5gVHhFQECJfnK03Wo8kHIbPBOJhvvvEPBjmYMrREq33scGMBKL29A7ng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677764075; a=rsa-sha256; cv=none; b=bC1c682X8Clhdkw7basL1H5ftuatzkn/tCkigAsLpCAMabKT1DfEvgpsSLLjKpUT0CNpPi vkupSafkEhaAz60uF+NAJrkofKIMtSV/kAQvNowHEfHfR7csOITYMg0//ywRcXfrfzUo9t ob3Z08v74mXfIFkGMhnVdDAI4elUpZmLZISPkgZbjrXeQaZCyLISkmJ1GgWFldg4/nzq7k Qi+JOxGEcY/6u1y9Uxb34AKaBWtpJX7rvPsuq10OPjoUj7yUWMQ3+5b/lpzp8xcgwpJb6+ P1hWEoxba43u8hGQ/8F/uiB1OMxZrCvd7Ods2dDiBejyIscvM/aihOxvSr1rIA== Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PSBsl2TVVzVNq; Thu, 2 Mar 2023 13:34:35 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f49.google.com with SMTP id f13so22392235vsg.6; Thu, 02 Mar 2023 05:34:35 -0800 (PST) X-Gm-Message-State: AO0yUKWuoD96UamuA4Q4ADU51+MefgGJclIi5uipGlgsSm+Sn6erjIt3 w29VUiN/nQcbd/RlNtt7GEQGiw+PKZfljNfm7dE= X-Google-Smtp-Source: AK7set/Zx3GeGY9CeX4pl1OnupGhCANJuFi/fsPqlx4LW4fjaKz8JIFtNwE+gXEA1bdBI3tqjW47irOeGI49AcACmMU= X-Received: by 2002:a05:6102:802:b0:411:fff6:3cc4 with SMTP id g2-20020a056102080200b00411fff63cc4mr6747488vsb.3.1677764074511; Thu, 02 Mar 2023 05:34:34 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202302271328.31RDScwO056423@gitrepo.freebsd.org> <04e9e204-a2f1-cbac-c7ff-d07f70ba1738@FreeBSD.org> In-Reply-To: <04e9e204-a2f1-cbac-c7ff-d07f70ba1738@FreeBSD.org> From: Nuno Teixeira Date: Thu, 2 Mar 2023 13:34:22 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: e7b134bf62ce - main - devel/aws-sdk-cpp: Update to 1.11.25 To: Danilo Egea Gondolfo Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000ada60d05f5eae347" X-ThisMailContainsUnwantedMimeParts: N --000000000000ada60d05f5eae347 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Danilo, I will test it on i386 too to figure it out. If it is like you said, I'll remove broken_tests very soon. Thanks, Danilo Egea Gondolfo escreveu no dia segunda, 27/02/2023 =C3=A0(s) 16:32: > On 27/02/2023 14:30, Danilo Egea Gondolfo wrote: > > > On 27/02/2023 13:28, Nuno Teixeira wrote: > > > >> The branch main has been updated by eduardo: > >> > >> URL: > >> > https://cgit.FreeBSD.org/ports/commit/?id=3De7b134bf62ce15bd1daf1f7fbed51= 2262baa8eea > >> > >> commit e7b134bf62ce15bd1daf1f7fbed512262baa8eea > >> Author: Nuno Teixeira > >> AuthorDate: 2023-02-27 09:00:18 +0000 > >> Commit: Nuno Teixeira > >> CommitDate: 2023-02-27 13:28:07 +0000 > >> > >> devel/aws-sdk-cpp: Update to 1.11.25 > >> - fix TEST option that was wrongly set to ON and causing > >> build failures > >> on some 32bit archs. > >> - unbreak on mentioned archs > > > > Interesting. Does that mean the build will not work on 32bit archs if > > TEST is enabled? > > > > As the former maintainer of devel/aws-sdk-cpp I'm just curious. > > > > I didn't really try but if it's building on 32bit archs now the real > > reason might be this refactoring mentioned in the changelog for > > version 1.11.0 > > > > > https://github.com/aws/aws-sdk-cpp/blob/main/CHANGELOG.md#1110-2022-01-24 > > > > The build would fail before because they generate huge unified cpp > > files (option ENABLE_UNITY_BUILD) that were making a single instance > > of the compiler to use more than 4GB of memory (more than 6GB actually > > on 64bit). > > > > Anyway, I'm glad you fixed it for 32 bit archs. Thanks :) > > > Just test on i386. The build failed with tests because there are tests > failing, not because the compiler is consuming too much memory. > > I'd say those TEST_BROKEN could all be removed. > > > >> ChangeLog: > >> https://github.com/aws/aws-sdk-cpp/compare/1.11.10...1.11.25 > >> PR: 269837 > >> Reported by: John Hein > >> --- > >> devel/aws-sdk-cpp/Makefile | 13 ++++++------- > >> devel/aws-sdk-cpp/distinfo | 6 +++--- > >> 2 files changed, 9 insertions(+), 10 deletions(-) > >> > >> diff --git a/devel/aws-sdk-cpp/Makefile b/devel/aws-sdk-cpp/Makefile > >> index 94de9263a751..608d138e75bb 100644 > >> --- a/devel/aws-sdk-cpp/Makefile > >> +++ b/devel/aws-sdk-cpp/Makefile > >> @@ -1,5 +1,5 @@ > >> PORTNAME=3D aws-sdk-cpp > >> -DISTVERSION=3D 1.11.10 > >> +DISTVERSION=3D 1.11.25 > >> CATEGORIES=3D devel > >> MAINTAINER=3D eduardo@FreeBSD.org > >> @@ -9,11 +9,6 @@ WWW=3D https://github.com/aws/aws-sdk-cpp > >> LICENSE=3D APACHE20 > >> LICENSE_FILE=3D ${WRKSRC}/LICENSE > >> -BROKEN_armv6=3D fails to build: runaway process > >> -BROKEN_armv7=3D fails to build: runaway process > >> -BROKEN_i386=3D fails to build: compiler runs out of memory > >> -BROKEN_powerpc=3D fails to build: compiler runs out of memory > >> - > >> LIB_DEPENDS=3D libaws-c-auth.so:security/aws-c-auth \ > >> libaws-c-cal.so:security/aws-c-cal \ > >> libaws-c-common.so:devel/aws-c-common \ > >> @@ -58,7 +53,11 @@ BUILD_ONLY?=3D > >> OPTIONS_DEFINE=3D TEST > >> OPTIONS_SUB=3D yes > >> -TEST_CMAKE_BOOL_OFF=3D ENABLE_TESTING > >> +TEST_CMAKE_BOOL=3D ENABLE_TESTING > >> +TEST_BROKEN_armv6=3D fails to build: runaway process > >> +TEST_BROKEN_armv7=3D fails to build: runaway process > >> +TEST_BROKEN_i386=3D fails to build: compiler runs out of memory > >> +TEST_BROKEN_powerpc=3D fails to build: compiler runs out of memory > >> pre-everything:: > >> @${ECHO_MSG} > >> diff --git a/devel/aws-sdk-cpp/distinfo b/devel/aws-sdk-cpp/distinfo > >> index df6d21d967f7..2a639227971b 100644 > >> --- a/devel/aws-sdk-cpp/distinfo > >> +++ b/devel/aws-sdk-cpp/distinfo > >> @@ -1,3 +1,3 @@ > >> -TIMESTAMP =3D 1675456421 > >> -SHA256 (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) =3D > >> e1370a57252147df35bd8860f35ad69548bb46077adf7524c2d1dd02ee8aa643 > >> -SIZE (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) =3D 49752262 > >> +TIMESTAMP =3D 1677440274 > >> +SHA256 (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) =3D > >> 1103cf18516ca70d76c062af5a2b5c2418c5162235895baf3550a9f356d69f10 > >> +SIZE (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) =3D 49938123 > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000ada60d05f5eae347 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Danilo,

I will test it= on i386 too to figure it out.
If it is like you said, I'll r= emove broken_tests very soon.

Thanks,

Dan= ilo Egea Gondolfo <danilo@freebsd.= org> escreveu no dia segunda, 27/02/2023 =C3=A0(s) 16:32:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">On 27/02/2023 14:30, Danil= o Egea Gondolfo wrote:

> On 27/02/2023 13:28, Nuno Teixeira wrote:
>
>> The branch main has been updated by eduardo:
>>
>> URL:
>> https:/= /cgit.FreeBSD.org/ports/commit/?id=3De7b134bf62ce15bd1daf1f7fbed512262baa8e= ea
>>
>> commit e7b134bf62ce15bd1daf1f7fbed512262baa8eea
>> Author:=C2=A0=C2=A0=C2=A0=C2=A0 Nuno Teixeira <eduardo@FreeBSD.= org>
>> AuthorDate: 2023-02-27 09:00:18 +0000
>> Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Nuno Teixeira <eduardo@FreeBSD.= org>
>> CommitDate: 2023-02-27 13:28:07 +0000
>>
>> =C2=A0=C2=A0=C2=A0=C2=A0 devel/aws-sdk-cpp: Update to 1.11.25
>> =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 - fix TEST optio= n that was wrongly set to ON and causing
>> build failures
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 on some 32bit archs.
>> =C2=A0=C2=A0=C2=A0=C2=A0 - unbreak on mentioned archs
>
> Interesting. Does that mean the build will not work on 32bit archs if =
> TEST is enabled?
>
> As the former maintainer of devel/aws-sdk-cpp I'm just curious. >
> I didn't really try but if it's building on 32bit archs now th= e real
> reason might be this refactoring mentioned in the changelog for
> version 1.11.0
>
> https://github.com/aws= /aws-sdk-cpp/blob/main/CHANGELOG.md#1110-2022-01-24
>
> The build would fail before because they generate huge unified cpp > files (option ENABLE_UNITY_BUILD) that were making a single instance <= br> > of the compiler to use more than 4GB of memory (more than 6GB actually=
> on 64bit).
>
> Anyway, I'm glad you fixed it for 32 bit archs. Thanks :)
>
Just test on i386. The build failed with tests because there are tests
failing, not because the compiler is consuming too much memory.

I'd say those TEST_BROKEN could all be removed.


>> =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ChangeLog:
>> https://github.com/aws/aws-sdk-= cpp/compare/1.11.10...1.11.25
>> =C2=A0=C2=A0=C2=A0=C2=A0 PR:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 269837
>> =C2=A0=C2=A0=C2=A0=C2=A0 Reported by:=C2=A0=C2=A0=C2=A0 John Hein = <jcfyecra= yz@liamekaens.com>
>> ---
>> =C2=A0 devel/aws-sdk-cpp/Makefile | 13 ++++++-------
>> =C2=A0 devel/aws-sdk-cpp/distinfo |=C2=A0 6 +++---
>> =C2=A0 2 files changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/devel/aws-sdk-cpp/Makefile b/devel/aws-sdk-cpp/Makefi= le
>> index 94de9263a751..608d138e75bb 100644
>> --- a/devel/aws-sdk-cpp/Makefile
>> +++ b/devel/aws-sdk-cpp/Makefile
>> @@ -1,5 +1,5 @@
>> =C2=A0 PORTNAME=3D=C2=A0=C2=A0=C2=A0 aws-sdk-cpp
>> -DISTVERSION=3D=C2=A0=C2=A0=C2=A0 1.11.10
>> +DISTVERSION=3D=C2=A0=C2=A0=C2=A0 1.11.25
>> =C2=A0 CATEGORIES=3D=C2=A0=C2=A0=C2=A0 devel
>> =C2=A0 =C2=A0 MAINTAINER=3D=C2=A0=C2=A0=C2=A0 eduardo@FreeBSD.org<= br> >> @@ -9,11 +9,6 @@ WWW=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = https://github.com/aws/aws-sdk-cpp
>> =C2=A0 LICENSE=3D=C2=A0=C2=A0=C2=A0 APACHE20
>> =C2=A0 LICENSE_FILE=3D=C2=A0=C2=A0=C2=A0 ${WRKSRC}/LICENSE
>> =C2=A0 -BROKEN_armv6=3D=C2=A0=C2=A0=C2=A0 fails to build: runaway = process
>> -BROKEN_armv7=3D=C2=A0=C2=A0=C2=A0 fails to build: runaway process=
>> -BROKEN_i386=3D=C2=A0=C2=A0=C2=A0 fails to build: compiler runs ou= t of memory
>> -BROKEN_powerpc=3D=C2=A0=C2=A0=C2=A0 fails to build: compiler runs= out of memory
>> -
>> =C2=A0 LIB_DEPENDS=3D=C2=A0=C2=A0=C2=A0 libaws-c-auth.so:security/= aws-c-auth \
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 libaws-c-ca= l.so:security/aws-c-cal \
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 libaws-c-co= mmon.so:devel/aws-c-common \
>> @@ -58,7 +53,11 @@ BUILD_ONLY?=3D
>> =C2=A0 OPTIONS_DEFINE=3D=C2=A0=C2=A0=C2=A0 TEST
>> =C2=A0 OPTIONS_SUB=3D=C2=A0=C2=A0=C2=A0 yes
>> =C2=A0 -TEST_CMAKE_BOOL_OFF=3D=C2=A0=C2=A0=C2=A0 ENABLE_TESTING >> +TEST_CMAKE_BOOL=3D=C2=A0=C2=A0=C2=A0 ENABLE_TESTING
>> +TEST_BROKEN_armv6=3D=C2=A0=C2=A0=C2=A0 fails to build: runaway pr= ocess
>> +TEST_BROKEN_armv7=3D=C2=A0=C2=A0=C2=A0 fails to build: runaway pr= ocess
>> +TEST_BROKEN_i386=3D=C2=A0=C2=A0=C2=A0 fails to build: compiler ru= ns out of memory
>> +TEST_BROKEN_powerpc=3D=C2=A0=C2=A0=C2=A0 fails to build: compiler= runs out of memory
>> =C2=A0 =C2=A0 pre-everything::
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 @${ECHO_MSG}
>> diff --git a/devel/aws-sdk-cpp/distinfo b/devel/aws-sdk-cpp/distin= fo
>> index df6d21d967f7..2a639227971b 100644
>> --- a/devel/aws-sdk-cpp/distinfo
>> +++ b/devel/aws-sdk-cpp/distinfo
>> @@ -1,3 +1,3 @@
>> -TIMESTAMP =3D 1675456421
>> -SHA256 (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) =3D
>> e1370a57252147df35bd8860f35ad69548bb46077adf7524c2d1dd02ee8aa643 >> -SIZE (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) =3D 49752262
>> +TIMESTAMP =3D 1677440274
>> +SHA256 (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) =3D
>> 1103cf18516ca70d76c062af5a2b5c2418c5162235895baf3550a9f356d69f10 >> +SIZE (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) =3D 49938123


--
Nun= o Teixeira
FreeBSD Committer (ports)
--000000000000ada60d05f5eae347--