From owner-cvs-src Mon Feb 17 22:37:19 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6455337B401; Mon, 17 Feb 2003 22:37:17 -0800 (PST) Received: from cain.gsoft.com.au (genesi.lnk.telstra.net [139.130.136.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D2B343F93; Mon, 17 Feb 2003 22:37:13 -0800 (PST) (envelope-from doconnor@gsoft.com.au) Received: from [127.0.0.1] (localhost [127.0.0.1]) by cain.gsoft.com.au (8.12.4/8.12.6) with ESMTP id h1I6b7js023046; Tue, 18 Feb 2003 17:07:08 +1030 (CST) (envelope-from doconnor@gsoft.com.au) X-Authentication-Warning: cain.gsoft.com.au: Host localhost [127.0.0.1] claimed to be [127.0.0.1] Subject: Re: cvs commit: src/sys/i386/include pci_cfgreg.h src/sys/i386/pci pci_bus.c pci_cfgreg.c src/sys/kern subr_witness.c From: "Daniel O'Connor" To: Peter Wemm Cc: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG In-Reply-To: <20030218061831.B82A32A89E@canning.wemm.org> References: <20030218061831.B82A32A89E@canning.wemm.org> Content-Type: text/plain Organization: Message-Id: <1045550227.34597.30.camel@chowder.gsoft.com.au> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Date: 18 Feb 2003 17:07:07 +1030 Content-Transfer-Encoding: 7bit X-Spam-Score: -1 () CARRIAGE_RETURNS,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,SPAM_PHRASE_00_01 X-Scanned-By: MIMEDefang 2.16 (www . roaringpenguin . com / mimedefang) Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 2003-02-18 at 16:48, Peter Wemm wrote: > Incidently, did anybody know that it is utterly unsafe to use > pci_read_config() or pci_write_config() in interrupt handlers on RELENG_4? > And yes, lots of drivers do it a lot! :-( Unfortunately most of this stuff seems to be undocumented :( Speaking as someone who has written a driver for 3.x & 4.x it really sucks when your only reference is other drivers, because there are no man pages or web pages that are up to date. Very easy to make these kind of mistakes since you copy from someone else (who copied it from ...) (And no, I don't have any man pages or diffs) -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 9A8C 569F 685A D928 5140 AE4B 319B 41F4 5D17 FDD5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message