From owner-freebsd-doc@FreeBSD.ORG Mon Jan 19 13:03:33 2009 Return-Path: Delivered-To: doc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D3119106564A; Mon, 19 Jan 2009 13:03:33 +0000 (UTC) (envelope-from sonic2000gr@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.171]) by mx1.freebsd.org (Postfix) with ESMTP id 2F9998FC19; Mon, 19 Jan 2009 13:03:32 +0000 (UTC) (envelope-from sonic2000gr@gmail.com) Received: by ug-out-1314.google.com with SMTP id 30so197085ugs.39 for ; Mon, 19 Jan 2009 05:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=5TjrT77HxCptMt6w4U2rR47lPzNCtizdtXKg4WeXPaM=; b=QPC0vXplc9Jx+kHQFIXGLPICU+rMgjxRbNq2as8qPWEujtcn9WqjXVAOphM7tOu8/j lC7cA+rufFjzdIqKFkpwRqKt2sJu39gOcMXNhWSaMBco+csdL7wExGxApQTfy0LYcZcU zWAmHSryotqFzlH2j8VjRELCgSy8lwOBOnDA8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=XZ6b1Ixpsumm15ULEyhejI2m3yhrJk/so0TTmfAxjUVqFKccBS3ug6Ead5YLuaAzYX 0Wu9hxAtz3zvqdYQp077vHT3cOPM/9TSgS8OiMj+F+1asBNmGNXO91QWg2ZRyXMly0Bc iB2ZtZoYL6ku6ywlf7zcgoWYLwYcZItltMb5E= Received: by 10.66.220.17 with SMTP id s17mr1510091ugg.69.1232370212148; Mon, 19 Jan 2009 05:03:32 -0800 (PST) Received: from atlantis.dyndns.org (athedsl-90230.home.otenet.gr [87.203.105.196]) by mx.google.com with ESMTPS id k28sm9771637ugd.15.2009.01.19.05.03.27 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 19 Jan 2009 05:03:30 -0800 (PST) Message-ID: <49747A1E.1080005@gmail.com> Date: Mon, 19 Jan 2009 15:03:26 +0200 From: Manolis Kiagias User-Agent: Thunderbird 2.0.0.17 (X11/20081011) MIME-Version: 1.0 To: Gabor PALI References: <685a6ef80901162151n36faf048tdad36c7a85c05731@mail.gmail.com> In-Reply-To: <685a6ef80901162151n36faf048tdad36c7a85c05731@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: doc@freebsd.org Subject: Re: Patches to the FDP Primer (from Last Year) X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2009 13:03:34 -0000 Gabor PALI wrote: > Folks, > > I created some patches for you to review during the translation of the > mighty FreeBSD Documentation Project Primer. Well, it has been a > while ago, but I think some things still should be fixed up. > > Here are the significant ones (others could be found in the same > directory, they usually fix typos, markup and capitalization as well > as the highlighted patches partially): > > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.doc-build.patch.diff > - Remove description of (documentation) package target as it is not > supported and it will be changed. Of course, the target in question > still lives in the Makefiles, but I would not mention it any more > (only when resurrected in some form). > So is the 'package' target broken? Admittedly I've never used it before reading your patch, but it seems it worked for me, building a package for the fdp-primer. I could install it with pkg_add, but then pkg_delete errored out trying to uninstall it. Not sure whether we should completely remove it from the docs though. The rest of the patch looks ok to me. > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.psgml-mode.patch.diff > - Mark up Emacs functions with rather than > - Add port reference for editors/psgml > > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.see-also.patch.diff > - Fix broken links > > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.structure.patch.diff > - Rewrite the sentences about the Handbook images to provide more > up-to-date information instead of mentioning the possibility of > including images in a book > - Add some note on the localization of those images > > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.the-website.patch.diff > - Add a description about WEB_LANG > > > All these look fine to me! > Note that I plan to bump the copyright year after the commits as there > are some content changes hiding in my proposed changes. > > Thank you in advance. > > Cheers, > :g > > > PS: I want to touch the "Translations" chapter too, but I still have > not got time to compose a usable patch for that. > _______________________________________________ > This is all nice work. I've been struggling with the translation of ppp-and-slip lately (plus I had rather limited spare time), hence the late reply. I think it would be ok to commit all the above, maybe get a few opinions on removing the reference to the package target. I see no other problems. Cheers, Manolis