Date: Sat, 8 Jun 1996 08:17:22 +1000 From: Bruce Evans <bde@zeta.org.au> To: CVS-committers@freefall.freebsd.org, ache@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org Subject: Re: cvs commit: src/etc/etc.i386 MAKEDEV Message-ID: <199606072217.IAA05698@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified: etc/etc.i386 MAKEDEV > Log: > IDE cd fixes: > wcd?a is missing > wrong partition number was used for wcd?c I thought that it had some reason for being different from cd's, mcd's and scd's. Now it is no different (it uses a stupid umask but chmod's to the correct mode so the results are the same). It should never have been different. Now only the matcd devices are different from other cd devices. They shouldn't be. Don't forget to keep devfs up to date with MAKEDEV. I only do it for the devices that I have. Devfs seems to already create wcd?a, but it uses the wrong mode (600, should be 640), and more- hard-coded ids (WDC_UID = 0 should be ROOT_UID; WDC_GID = 13 should be GID_OPERATOR), and hard-coded minor numbers ((lun * 8) + RAW_PART) should be dkmakeminor(lun, 0, RAW_PART)). Devfs's matcd, mcd and scd are wrong in the same ways, except for matcd the minor number encoding is wronger (only works for one unit). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199606072217.IAA05698>