Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Nov 1998 17:14:54 +0900
From:      okazaki@be.to
To:        FreeBSD-gnats-submit@FreeBSD.ORG
Subject:   ports/8859: apache13 __FreeBSD_version is checked before its definition.
Message-ID:  <19981125171454F.okazaki@be.to>

next in thread | raw e-mail | index | archive | help

>Number:         8859
>Category:       ports
>Synopsis:       apache13 __FreeBSD_version is checked before its definition.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 25 00:30:00 PST 1998
>Last-Modified:
>Originator:     OKAZAKI Tetsurou
>Organization:
Japan FreeBSD Users' Group
>Release:        FreeBSD 2.2.6-RELEASE i386
>Environment:

FreeBSD pc10.localnet.jp 2.2.6-RELEASE FreeBSD 2.2.6-RELEASE #4: Sun Nov  8 04:12:36 JST 1998     refactor@pc10.localnet.jp:/usr/src/sys/compile/TUNED  i386

>Description:

In ${WRKDIR}/src/os/unix/os.h, __FreeBSD_version is checked while
it is not defined yet, so DLSYM_NEEDS_UNDERSCORE is always undefined.
Of course, this is not a problem to users of late 2.2.x-RELEASE(s),
STABLE and CURRENT, but some early 2.2.x-RELEASE.

Above description can be applied to
www/apache13/patches/patch-am,
www/apache13-fp/patches/patch-an,
www/apache13-modssl/patches/patch-ag.

>How-To-Repeat:

make patch
Edit work/apache_1.3.3/src/os/unix/os.h. (insert three lines as follows)
  ...
 +#ifndef __FreeBSD_version
 +#error "__FreeBSD_version is not defined yet."
 +#endif

  #if (defined(__FreeBSD_version) && (__FreeBSD_version < 300004)) || ...
  #define DLSYM_NEEDS_UNDERSCORE
  #endif
  ...

make build
...
===>  Building for apache-1.3.3
===> src
===> src/os/unix
cc -c  -I../../os/unix -I../../include  -DHARD_SERVER_LIMIT=512  -DDOCUMENT_LOCATION=\"/usr/local/www/data/\"  -DDEFAULT_PATH=\"/bin:/usr/bin:/usr/local/bin\" -funsigned-char -O `../../apaci` os.c
In file included from ../../include/ap_config.h:92,
                 from os.c:6:
../../os/unix/os.h:125: #error "__FreeBSD_version is not defined yet."
*** Error code 1

Stop.


>Fix:
	
Please apply the following patch. 
NOTE: this is a patch for the www/apache13!


--- /usr/ports/current/www/apache13/patches/patch-am    Mon Oct 19 21:48:59 1998
+++ apache13/patches/patch-am   Mon Nov 23 00:14:10 1998
@@ -1,5 +1,5 @@
-*** src/os/unix/os.h.orig      Thu Oct 15 09:31:30 1998
---- src/os/unix/os.h   Thu Oct 15 09:33:11 1998
+*** src/os/unix/os.h.orig      Wed Sep 16 15:49:44 1998
+--- src/os/unix/os.h   Mon Nov 23 00:10:49 1998
 ***************
 *** 121,127 ****
   #define RTLD_GLOBAL 0
@@ -9,10 +9,14 @@
   #define DLSYM_NEEDS_UNDERSCORE
   #endif
   
---- 121,127 ----
+--- 121,131 ----
   #define RTLD_GLOBAL 0
   #endif
   
+! #if __FreeBSD__ >= 2
+! #include <osreldate.h>
+! #endif
+! 
 ! #if (defined(__FreeBSD_version) && (__FreeBSD_version < 300004)) || defined(__OpenBSD__) || defined(__NetBSD__)
   #define DLSYM_NEEDS_UNDERSCORE
   #endif


>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19981125171454F.okazaki>