From owner-cvs-src@FreeBSD.ORG Thu Oct 2 18:30:34 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1368106568C; Thu, 2 Oct 2008 18:30:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 421D08FC2A; Thu, 2 Oct 2008 18:30:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m92IULIq083774; Thu, 2 Oct 2008 14:30:28 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Warner Losh Date: Thu, 2 Oct 2008 13:05:47 -0400 User-Agent: KMail/1.9.7 References: <200810020629.m926TqZq036159@repoman.freebsd.org> In-Reply-To: <200810020629.m926TqZq036159@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810021305.47479.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Thu, 02 Oct 2008 14:30:28 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8372/Thu Oct 2 11:21:47 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pccbb pccbb_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2008 18:30:34 -0000 On Thursday 02 October 2008 02:29:45 am Warner Losh wrote: > imp 2008-10-02 06:29:45 UTC > > FreeBSD src repository > > Modified files: > sys/dev/pccbb pccbb_pci.c > Log: > SVN rev 183539 on 2008-10-02 06:29:45Z by imp > > Don't forget to match on a CLASS of PCIC_BRIDGE as well as subclass > PCIS_BRIDGE_CARDBUS. Otherwise, we may hit a few false positives.... Shouldn't it use BUS_GENERIC_PROBE instead of BUS_DEFAULT_PROBE when matching purely on the class codes? -- John Baldwin