From owner-freebsd-current Sun Jan 20 12: 7:18 2002 Delivered-To: freebsd-current@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 83CF237B417; Sun, 20 Jan 2002 12:07:16 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 481B3532C; Sun, 20 Jan 2002 21:07:15 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "Andrey A. Chernov" Cc: markm@freebsd.org, current@freebsd.org Subject: Re: Step2, pam_unix just expired pass fix for review References: <20020120191711.GA23576@nagual.pp.ru> <20020120195407.GA24138@nagual.pp.ru> From: Dag-Erling Smorgrav Date: 20 Jan 2002 21:07:14 +0100 In-Reply-To: <20020120195407.GA24138@nagual.pp.ru> Message-ID: Lines: 19 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Andrey A. Chernov" writes: > On Sun, Jan 20, 2002 at 20:41:09 +0100, Dag-Erling Smorgrav wrote: > > pam_sm_acct_mgmt() is allowed to return PAM_AUTHTOK_EXPIRED (which is > > a better return value than PAM_AUTH_ERR for this case). Other than > > that, I have no objections to your patch. > This is fix for pam_sm_authenticate(), not for pam_sm_acct_mgmt(). Is > pam_sm_authenticate() allowed to return PAM_AUTHTOK_EXPIRED too? I don't > find it in allowed return codes list. I misread your mail. Pam_sm_authenticate() is not supposed to care that the password is expired. If it did, it users with expired passwords would be effectively locked out; they're supposed to get a chance to change their password. The application is supposed to call pam_chauthtok() if pam_acct_mgmt() returns PAM_AUTHTOK_EXPIRED; see the sample application in DCE RFC 86.0. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message