From owner-freebsd-hackers@FreeBSD.ORG Sun Oct 28 19:13:47 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4209A445; Sun, 28 Oct 2012 19:13:47 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id D20228FC0A; Sun, 28 Oct 2012 19:13:46 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id wc20so5182133obb.13 for ; Sun, 28 Oct 2012 12:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ap+O/nlbV3gjVYp2i7oLgjmJAQ7UyBqleBcBeuF99oQ=; b=G3dMw+aPfZqbdfFZW01Xbs5rJW/hsc6lEMdncbES+B/hZJ9F6B6cHBIPZ9mqeGba5h xUxIOhy8u3M/VIFrm7pjc4uiOMoSeEtRMmKOXnGE6Y5OxRLLxCRnym43nEBQFFsErrWr hnHSwoXf4KpefAtdqhHSNIQxepNmj6PzBTAmILZhZ0i2fxQAiWBUaX5ByEaPFt5JD0IU C+D9qd0bP4OnFRIoRtX298c/51k/kAh3U4KMgi7fypytlYo/XQD5eeW9BKA9K8o9GF0e ikCo6w+zPTazTuAIJAmMrQnAJbMPsyjaXvgvzKwfLcBFZN+z7Xdi6lByFN51sUxGI/MF g0FA== MIME-Version: 1.0 Received: by 10.182.131.100 with SMTP id ol4mr23056249obb.38.1351451626233; Sun, 28 Oct 2012 12:13:46 -0700 (PDT) Received: by 10.76.143.33 with HTTP; Sun, 28 Oct 2012 12:13:46 -0700 (PDT) In-Reply-To: References: <508D0F11.1060203@kovesdan.org> Date: Sun, 28 Oct 2012 12:13:46 -0700 Message-ID: Subject: Re: Porting patch(1) from NetBSD to FreeBSD (was Re: FreeBSD in Google Code-In 2012? You can help too!) From: Garrett Cooper To: Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 Cc: Gabor Kovesdan , freebsd-hackers@freebsd.org, Pedro Giffuni , hiren panchasara X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 19:13:47 -0000 On Sun, Oct 28, 2012 at 9:07 AM, Adrian Chadd wrote: > On 28 October 2012 03:55, Gabor Kovesdan wrote: > >> Hi Hiren, >> >> good to hear that someone is working on this! However, porting these >> utilies is much tougher than it apparently seems. There are much more >> criteria than just it compiles and works. More specifically, you should >> make sure that: > > [snip] > > * It's totally bug compatible for now with gnu patch/diff. > * You write a _lot_ of test cases for the test framework, so people > can do automated regression testing on both performance and behaviour. > > It'd be nice to have more regression testing. :-) If you're looking for bug compatibility with GNU patch, I would start with the tests produced by upstream [1] as a base for determining how compatible BSD patch really is. Similar steps could and should have been done for BSD grep [2] (unfortunately GNU sort doesn't have any tests, but if we develop the guts (inputs and expected output) of some tests and commit them back to GNU, I'm sure they would appreciate it). Thanks, -Garrett 1. http://git.savannah.gnu.org/cgit/patch.git/tree/tests 2. http://git.savannah.gnu.org/cgit/grep.git/tree/tests