Date: Sat, 15 Sep 2018 17:22:05 +0000 (UTC) From: Ed Maste <emaste@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r479840 - head/multimedia/xmms Message-ID: <201809151722.w8FHM5Gm023445@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: emaste (src committer) Date: Sat Sep 15 17:22:04 2018 New Revision: 479840 URL: https://svnweb.freebsd.org/changeset/ports/479840 Log: multimedia/xmms: add -znotext to LDFLAGS on i386, for lld Example error: /usr/bin/ld: error: can't create dynamic relocation R_386_32 against local symbol in readonly segment; recompile object files with -fPIC This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default. Modified: head/multimedia/xmms/Makefile Modified: head/multimedia/xmms/Makefile ============================================================================== --- head/multimedia/xmms/Makefile Sat Sep 15 16:13:49 2018 (r479839) +++ head/multimedia/xmms/Makefile Sat Sep 15 17:22:04 2018 (r479840) @@ -23,6 +23,9 @@ USE_GNOME= gtk12 USE_LDCONFIG= yes USE_XORG= sm x11 xxf86vm +LDFLAGS+= ${LDFLAGS_${ARCH}} +LDFLAGS_i386= -Wl,-znotext + CONFIGURE_ARGS= xmms_cv_newpcm_driver=yes --disable-static CONFIGURE_ENV= INPUT_PLUGINS="${INPUT_PLUGINS}" \ OUTPUT_PLUGINS="${OUTPUT_PLUGINS}" \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809151722.w8FHM5Gm023445>