From owner-cvs-all@FreeBSD.ORG Tue Nov 27 09:09:10 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3882316A46C; Tue, 27 Nov 2007 09:09:10 +0000 (UTC) (envelope-from benjsc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0E90313C4F6; Tue, 27 Nov 2007 09:09:10 +0000 (UTC) (envelope-from benjsc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lAR9996a025110; Tue, 27 Nov 2007 09:09:09 GMT (envelope-from benjsc@repoman.freebsd.org) Received: (from benjsc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lAR9990r025109; Tue, 27 Nov 2007 09:09:09 GMT (envelope-from benjsc) Message-Id: <200711270909.lAR9990r025109@repoman.freebsd.org> From: Benjamin Close Date: Tue, 27 Nov 2007 09:09:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/wpi if_wpi.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2007 09:09:10 -0000 benjsc 2007-11-27 09:09:09 UTC FreeBSD src repository Modified files: sys/dev/wpi if_wpi.c Log: Fix up a race condition with the callout_stop method in newstate. The call should happen with the driver lock held. We don't hold the driver lock in newstate as it's a separate thread where we can't sleep (and we only call wpi_cmd in async mode). Discovered By: Attillo's callout rework Approved By: mlaier (comentor) Revision Changes Path 1.5 +4 -1 src/sys/dev/wpi/if_wpi.c