From owner-freebsd-numerics@FreeBSD.ORG Tue May 28 06:14:47 2013 Return-Path: Delivered-To: freebsd-numerics@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CEB00104; Tue, 28 May 2013 06:14:47 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from fallbackmx08.syd.optusnet.com.au (fallbackmx08.syd.optusnet.com.au [211.29.132.10]) by mx1.freebsd.org (Postfix) with ESMTP id 63285AF7; Tue, 28 May 2013 06:14:46 +0000 (UTC) Received: from mail10.syd.optusnet.com.au (mail10.syd.optusnet.com.au [211.29.132.191]) by fallbackmx08.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id r4S6EWp4011570; Tue, 28 May 2013 16:14:32 +1000 Received: from c122-106-156-23.carlnfd1.nsw.optusnet.com.au (c122-106-156-23.carlnfd1.nsw.optusnet.com.au [122.106.156.23]) by mail10.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id r4S6EDZX013018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 May 2013 16:14:14 +1000 Date: Tue, 28 May 2013 16:14:13 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: David Schultz Subject: Re: Use of C99 extra long double math functions after r236148 In-Reply-To: <20130528043205.GA3282@zim.MIT.EDU> Message-ID: <20130528155933.V1298@besplex.bde.org> References: <500DAD41.5030104@missouri.edu> <20120724113214.G934@besplex.bde.org> <501204AD.30605@missouri.edu> <20120727032611.GB25690@server.rulingia.com> <20120728125824.GA26553@server.rulingia.com> <501460BB.30806@missouri.edu> <20120728231300.GA20741@server.rulingia.com> <50148F02.4020104@missouri.edu> <20120729222706.GA29048@server.rulingia.com> <5015BB9F.90807@missouri.edu> <20130528043205.GA3282@zim.MIT.EDU> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.0 cv=e/de0tV/ c=1 sm=1 a=O6A2dy7pM2IA:10 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=Zc3-fPm5GV4A:10 a=MGBSo3QMWewO758DKTcA:9 a=CjuIK1q_8ugA:10 a=ebeQFi2P/qHVC0Yw9JDJ4g==:117 X-Mailman-Approved-At: Tue, 28 May 2013 11:40:29 +0000 Cc: Diane Bruce , Bruce Evans , John Baldwin , David Chisnall , Stephen Montgomery-Smith , freebsd-numerics@freebsd.org, Bruce Evans , Steve Kargl , Peter Jeremy , Warner Losh X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2013 06:14:47 -0000 On Mon, 27 May 2013, David Schultz wrote: > ... > Below is a diff of all the changes needed to integrate it. I have > a short list of style fixes, but otherwise I think what you have > is good: > - wrap lines to 80 chars, please > - spaces between operators > - "static inline", not "inline static" > - don't use "inline" on large functions Another reply. I think I tested "inline" on the large functions (just 2) and found it useful for efficiency. This is like inline on large trig support functions being useful. The inline parts are duplicated once per C99-API function, and often the caller only uses on C99-API function. Actually, the large inlines are not duplicated that much. cacosh() and casinh() are just wrappers that call cacos() and casin(), respectively. There is no inlining for the last 2 (even larger) functions. The overhead for the wrappers is noticeable, but more inlining didn't seem to reduce it much. More investigation of the extent of the style bugs: - only 1 line is longer than 80 columns now and easy to fix. Other long lines are for declarations where I prefer to keep the long comments on the same line - spaces between operations will expand a few lines beyond 80 columns if done blindly. Only a few. Bruce