From owner-freebsd-current  Thu Mar 29 13:13:56 2001
Delivered-To: freebsd-current@freebsd.org
Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88])
	by hub.freebsd.org (Postfix) with ESMTP id D948A37B71C
	for <current@FreeBSD.org>; Thu, 29 Mar 2001 13:13:52 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241])
	by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f2TLDXG40864;
	Thu, 29 Mar 2001 13:13:34 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.010329131309.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20010328231709.A96500@skriver.dk>
Date: Thu, 29 Mar 2001 13:13:09 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
To: Jesper Skriver <jesper@skriver.dk>
Subject: Re: NEWCARD broken in -current
Cc: current@FreeBSD.org,
	"Niels Chr. Bank-Pedersen" <ncbp@bank-pedersen.dk>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


On 28-Mar-01 Jesper Skriver wrote:
> On Wed, Mar 28, 2001 at 10:15:21PM +0200, Niels Chr. Bank-Pedersen wrote:
>> On Wed, Mar 28, 2001 at 10:09:28PM +0200, Jesper Skriver wrote:
>> > cc -c -O -pipe  -Wall -Wredundant-decls -Wnested-externs
>> > -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline
>> > -Wcast-qual  -fformat-extensions -ansi  -nostdinc -I-  -I.  -I/usr/src/sys
>> > -I/usr/src/sys/dev -I/usr/src/sys/../include -I/usr/src/sys/contrib/dev/acp
> ica/Subsystem/Include  -D_KERNEL -include opt_global.h -elf 
> -mpreferred-stack-boundary=2
>> > /usr/src/sys/dev/pccbb/pccbb.c
>> > In file included from /usr/src/sys/dev/pccbb/pccbb.c:56:
>> > /usr/src/sys/sys/mutex.h:87: field `mtx_object' has incomplete type
>> > /usr/src/sys/dev/pccbb/pccbb.c: In function `pccbb_detach':
>> > /usr/src/sys/dev/pccbb/pccbb.c:533: warning: implicit declaration of
>> > function `MPASS'
>> > /usr/src/sys/dev/pccbb/pccbb.c:533: warning: implicit declaration of
>> > function `LOCK_LOG_LOCK'
>> > /usr/src/sys/dev/pccbb/pccbb.c:533: warning: implicit declaration of
>> > function `WITNESS_LOCK'
>> > /usr/src/sys/dev/pccbb/pccbb.c:539: warning: implicit declaration of
>> > function `WITNESS_UNLOCK'
>> > *** Error code 1
>> 
>> You'll need to #include <sys/types.h> and <sys/lock.h>
>> in /usr/src/sys/dev/pccbb/pccbb.c
> 
> Right, the below fixes it, should I commit ?
> 
> Index: src/sys/dev/pccbb/pccbb.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/pccbb/pccbb.c,v
> retrieving revision 1.12
> diff -u -r1.12 pccbb.c
> --- src/sys/dev/pccbb/pccbb.c 2001/02/09 06:08:52     1.12
> +++ src/sys/dev/pccbb/pccbb.c 2001/03/28 20:51:20
> @@ -53,6 +53,8 @@
>  #include <sys/kernel.h>
>  #include <sys/kthread.h>
>  #include <sys/malloc.h>
> +#include <sys/types.h>
> +#include <sys/lock.h>
>  #include <sys/mutex.h>
>  
>  #include <sys/bus.h>

Please sort the includes or at least attempt to as that is style(9).  You'll
need to mvoe lock.h up before malloc.h.  types.h is special, it belongs as the
very first header unless sys/param.h is the first header (param.h includes
types.h).

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message