From owner-svn-src-head@freebsd.org Mon May 4 18:21:11 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 220582D6AD6; Mon, 4 May 2020 18:21:11 +0000 (UTC) (envelope-from gnikl@justmail.de) Received: from mout3.freenet.de (mout3.freenet.de [IPv6:2001:748:100:40::2:5]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (Client CN "*.freenet.de", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49GB4j6bfXz4YGC; Mon, 4 May 2020 18:21:09 +0000 (UTC) (envelope-from gnikl@justmail.de) Received: from [195.4.92.164] (helo=mjail1.freenet.de) by mout3.freenet.de with esmtpa (ID gnikl@justmail.de) (port 25) (Exim 4.92 #3) id 1jVfiE-0003sF-QT; Mon, 04 May 2020 20:21:06 +0200 Received: from [::1] (port=60568 helo=mjail1.freenet.de) by mjail1.freenet.de with esmtpa (ID gnikl@justmail.de) (Exim 4.92 #3) id 1jVfiE-0006Po-Pr; Mon, 04 May 2020 20:21:06 +0200 Received: from sub3.freenet.de ([195.4.92.122]:53872) by mjail1.freenet.de with esmtpa (ID gnikl@justmail.de) (Exim 4.92 #3) id 1jVffk-0004JT-L5; Mon, 04 May 2020 20:18:32 +0200 Received: from p5b3b3174.dip0.t-ipconnect.de ([91.59.49.116]:49737 helo=localhost) by sub3.freenet.de with esmtpsa (ID gnikl@justmail.de) (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256) (port 465) (Exim 4.92 #3) id 1jVffk-0003Wj-H2; Mon, 04 May 2020 20:18:32 +0200 Date: Mon, 4 May 2020 20:18:29 +0200 From: Gunther Nikl To: David Bright Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r360568 - head/sys/dev/nvme Message-ID: <20200504201540.00005dc5@justmail.de> In-Reply-To: <202005022047.042Klwcr068812@repo.freebsd.org> References: <202005022047.042Klwcr068812@repo.freebsd.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Originated-At: 91.59.49.116!49737 X-Rspamd-Queue-Id: 49GB4j6bfXz4YGC X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of gnikl@justmail.de has no SPF policy when checking 2001:748:100:40::2:5) smtp.mailfrom=gnikl@justmail.de X-Spamd-Result: default: False [-1.35 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-0.99)[-0.991,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[justmail.de]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-0.99)[-0.993,0]; IP_SCORE(-0.26)[ip: (-0.73), ipnet: 2001:748::/32(-0.27), asn: 5430(-0.29), country: DE(-0.02)]; RCVD_IN_DNSWL_NONE(0.00)[5.0.0.0.2.0.0.0.0.0.0.0.0.0.0.0.0.4.0.0.0.0.1.0.8.4.7.0.1.0.0.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5430, ipnet:2001:748::/32, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[116.49.59.91.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2020 18:21:11 -0000 Hello, > Modified: head/sys/dev/nvme/nvme_test.c > ============================================================================== > --- head/sys/dev/nvme/nvme_test.c Sat May 2 20:14:592020 (r360567) > +++ head/sys/dev/nvme/nvme_test.c Sat May 2 20:47:582020 (r360568) > @@ -100,7 +100,7 @@ nvme_ns_bio_test(void *arg) > idx = atomic_fetchadd_int(&io_test->td_idx, 1); > dev = io_test->ns->cdev; > - offset = idx * 2048 * nvme_ns_get_sector_size(io_test->ns); > + offset = idx * 2048ULL * nvme_ns_get_sector_size(io_test->ns); > > while (1) { I have read the differential where a cast was used on the 2048. AFAICT, the "ULL" is only correct if uint64 is a "unsigned long long". On a LP64 system it is normally a simple "unsigned long" and then the correct suffix would be "UL". In that sense the cast was probably more correct. my 2c Gunther