From owner-freebsd-arch@FreeBSD.ORG Sat Apr 8 05:04:28 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33ECE16A401 for ; Sat, 8 Apr 2006 05:04:28 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3E0F43D4C for ; Sat, 8 Apr 2006 05:04:27 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k3854G7t014412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Apr 2006 22:04:17 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <44374450.2070001@errno.com> Date: Fri, 07 Apr 2006 22:04:16 -0700 From: Sam Leffler User-Agent: Thunderbird 1.5 (X11/20060210) MIME-Version: 1.0 To: frank@exit.com References: <44370CD6.9090006@errno.com> <1144469861.21943.13.camel@realtime.exit.com> In-Reply-To: <1144469861.21943.13.camel@realtime.exit.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: arch@freebsd.org Subject: Re: ifnet cloning changes X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Apr 2006 05:04:28 -0000 Frank Mayhar wrote: > On Fri, 2006-04-07 at 18:07 -0700, Sam Leffler wrote: >> modifies the SIOCIFCREATE api in the kernel so that an opaque parameter >> block can be passed down to ifnet cloning routines (actually the user >> address is passed down and the caller must do the copyin since it alone >> knows the size of the parameter block). > > Isn't that a recipe for potential breakage? Why not make the api > receive a vector, i.e. buffer/length? The "caller" will know the actual > layout of the parameter block but other kernel routines will at least be > able to deal with it, since they'll know the size. Feel free to provide an alternative implementation; I'm not wed to the code. Sam