From owner-cvs-src@FreeBSD.ORG Fri May 2 10:17:01 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48D14106567A for ; Fri, 2 May 2008 10:17:01 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by mx1.freebsd.org (Postfix) with ESMTP id D0FC58FC33 for ; Fri, 2 May 2008 10:17:00 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by nf-out-0910.google.com with SMTP id h3so637596nfh.33 for ; Fri, 02 May 2008 03:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; bh=8r6U8yR1o2vWMm5B1luoPG3ZNGbKxoNHBesEKRhRGKE=; b=UyLtPC3zBYLI69Nl7T8mBQqA94XsiUIPSe5Z8GrcQ1hSIqzr31x+9HVeXDIn9xpD3YHHWtdax0/Op+HCEBctUpIvgXLpVHIj/oXKcjNYL7nT8h0hJloEWn+OeYLAkaINi1lGyCBI5YWQpm4pdK/IN2CsHuEg3feZ07gwParfA2I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=kBZz2uufkEbraJTD1Gk3ZfgsmkdIWjOjHnT3aFbV+ZO7Rp2ylvWCW7yRGzEyUpcw6vVhcTdqG4kdoFeJK4QLfRgXCR73j877CQMHJ9XDiGDSSWaQ1cJTDIz46/lRRCZAYv5JTJshQ343hnqWh+Evv8ZStl0tYGJ/ydrcQ6d1tPg= Received: by 10.210.23.3 with SMTP id 3mr2856702ebw.21.1209723419611; Fri, 02 May 2008 03:16:59 -0700 (PDT) Received: from epsilon.local ( [89.214.139.215]) by mx.google.com with ESMTPS id 5sm4999156nfv.37.2008.05.02.03.16.57 (version=SSLv3 cipher=RC4-MD5); Fri, 02 May 2008 03:16:58 -0700 (PDT) Message-ID: <481AEA17.7060702@FreeBSD.org> Date: Fri, 02 May 2008 11:16:55 +0100 From: Rui Paulo User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) MIME-Version: 1.0 To: John Baldwin References: <200802281910.m1SJAgm1083976@repoman.freebsd.org> <200805011547.07007.jhb@freebsd.org> <481A3406.8080007@FreeBSD.org> <200805011728.51152.jhb@freebsd.org> In-Reply-To: <200805011728.51152.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: Rui Paulo Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 May 2008 10:17:01 -0000 John Baldwin wrote: > On Thursday 01 May 2008 05:20:06 pm Rui Paulo wrote: >> John Baldwin wrote: >>> On Thursday 28 February 2008 02:10:42 pm Rui Paulo wrote: >>>> rpaulo 2008-02-28 19:10:42 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/i386/cpufreq est.c >>>> Log: >>>> Validate the id16 values gathered from ACPI (previously a TODO item). >>>> Style changes by me and njl. >>> What is the purpose of the 'saved_id16' variable? It is never used. I > think >>> what might be better is to just read it once at the start of the loop and >>> then restore it at the end of the loop, though phk@ has overwritten this > with >>> the "chew up all battery on laptops at all cost" patch. :-P >>> >> What do you mean by 'It is never used.' ? >> >> % cat -n est.c | grep saved_id16 >> 1082 uint16_t saved_id16; >> 1111 est_get_id16(&saved_id16); > > Right, it is initialized, but it's value isn't actually _used_ anywhere. > There isn't a est_set_id16(&saved_id16), etc. > Yes, you're right. Sorry, it was late yesterday :-) The variable is not necessary and has been removed. Thanks, -- Rui Paulo