From nobody Sat Jun 27 02:26:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gnGd61CFrz6jNb4 for ; Sat, 27 Jun 2026 02:26:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gnGd56C7Gz3Ndc for ; Sat, 27 Jun 2026 02:26:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782527193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=23nrGbg2wXAdJo+qTYkyXtEto8kyfFPcFGw5KB6qP5M=; b=fpzdD+xnd4kgO/y1kjFHEiFrzedyGHe4CE5TUF8CcoAcJtfa1tPE2N+73oLB8oDFiwMVx+ kf4bZnjUY7Qf11veca1yashFMjAiu9QoA1RgsfaElOvSOXu48nvjA8OcqZrD3L8SxaDAso m7bDAQa37UzgCc7YTdqj3PIL2ZMW9Vv6XtaflhMFiRHnZvEo68fgelstAFHCKZM1QXyCim o+sJoqVANRfwQEzlv0cuS1Lhe0BuwV3xkkPOYoghyQCQ1B+jspGEH6PzndhdCPn8XtQzCn 39TGqgS7Cakdhj90p7k+bIvhHQRMYd0PLNEjkEVyzNc2BmZKd9A6LhRS7fEg4Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782527193; a=rsa-sha256; cv=none; b=GcB+G+/ug6McU1N/fQogmS0s8C6fZNj5J0bZuCZhdoK5XPiUVPzK9Z7WeKvl+ONNr1YwTf ezZHmz1htcprS+xa6aEVM7jw7dAik1t8C14Zt2DZb+jUds/cS7/5xFK+PqxRboi32X3ET+ 8XIAr7326TtXlb62MpBH7EvQ+0Tfl74du9zGep8qUfz3IuRyBdSCwqBzhn5QiyiIoT7k3q wpv+geq7nKPyufgQol8Iy7tNY79ZT6goWJzimsszTsVayV7AH9oCdHrXdVYl5M/a9tMQS9 qVQLAl+954kVeRL+Wfpco4YcUpmMBgNAM9/umd/vf7LHckZ1HTR+R/2dLukK+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782527193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=23nrGbg2wXAdJo+qTYkyXtEto8kyfFPcFGw5KB6qP5M=; b=bU41Qz+Hy27wFNht7cHiniJr/dIiCnKrAscl2xCZ39hbPdZi27VIvt/fzrv9CD2BmvBegZ wQIDz+YxyBA9Dp+kcHpIlPkro4Ku/KF3xwL4TkeV7CpCmwITDOfxFvYGvvoyKZLZixtURP 1olGEKfewie21TZEzCm/37bpr/SVGeQW+E1XH55QLsbj5/yH9MOFITt2ZMsWqna9aeqOuE wKd0MDbAJpfW3cUrEsv64U+4+2E2atWK+OGkM8aXK3faZKEvUMhGT08m+99jj8wU3wOL/b TAu1N+3sDjwjiiYoo9f50fPPFiqrSHPMqf0BGM+AqCrw1SnvdUSO81VZcxLbYA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gnGd54zLPz13wx for ; Sat, 27 Jun 2026 02:26:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22f58 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 27 Jun 2026 02:26:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Li-Wen Hsu Subject: git: 8e61d8707f8a - main - libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: lwhsu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8e61d8707f8a10acc143210089fea2502a3f2922 Auto-Submitted: auto-generated Date: Sat, 27 Jun 2026 02:26:28 +0000 Message-Id: <6a3f34d4.22f58.4106286d@gitrepo.freebsd.org> The branch main has been updated by lwhsu: URL: https://cgit.FreeBSD.org/src/commit/?id=8e61d8707f8a10acc143210089fea2502a3f2922 commit 8e61d8707f8a10acc143210089fea2502a3f2922 Author: Li-Wen Hsu AuthorDate: 2026-06-27 02:26:05 +0000 Commit: Li-Wen Hsu CommitDate: 2026-06-27 02:26:05 +0000 libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode dt_print_sym() fills the symbol string via snprintf() in non-oformat mode but the guarding `dtp->dt_oformat != 0 &&` for the dt_printf() call causes the symbol is computed but never emitted. This fixes tests: - common.profile-n.t_dtrace_contrib.tst_sym_ksh - common.profile-n.t_dtrace_contrib.tst_func_ksh Reviewed by: markj Fixes: 93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option") MFC after: 3 days Event: Halifax Hackathon 202606 Location: Room 208, Computer Science Building, Dalhousie University Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57895 --- cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c index b311b5425587..a8a49b22ed7b 100644 --- a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c +++ b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c @@ -2143,7 +2143,7 @@ dt_print_sym(dtrace_hdl_t *dtp, FILE *fp, const char *format, caddr_t addr) } } - if (dtp->dt_oformat != 0 && dt_printf(dtp, fp, format, c) < 0) + if (!dtp->dt_oformat && dt_printf(dtp, fp, format, c) < 0) return (-1); return (0);