From owner-svn-src-all@freebsd.org Mon Jul 17 18:27:05 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9DD3D9D2BA for ; Mon, 17 Jul 2017 18:27:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A01C16B5F9 for ; Mon, 17 Jul 2017 18:27:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id k71so1195001iod.2 for ; Mon, 17 Jul 2017 11:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=cHwT+35kXkPEmEPYyb5FAgODGABfEj2PFxNwJ0qCtl4=; b=Nyq4eKDWDl3ThqzCVKj3W6pkyIDa8uACOQtOGvM3CtLd+oTlUAYP/fXkQZ8Qce+FHc /kyyA786Pq++ndhfDsropB8YdX9V5VqiSzVwGzw845ktYBux/ShioIDqnOFjosenQg73 eeE/snkoEWtM75p31GzHiU1M65zFK91fBobgq61lkr8K5ttuAYcQfNjvssIchGSv/Sb9 I12V1ecXrj69wi1Int97Dx2IGGWEwVB2e3BqvhbRKiBhiygRK/rBiSkqoYdcSizDI1rE lLA3AGGFjKI14YjsU+41hNfg3kJOix4c9rgOgvdqmsFeBwslLEGvHxZ5dS6hkhUWGoOP FgyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=cHwT+35kXkPEmEPYyb5FAgODGABfEj2PFxNwJ0qCtl4=; b=FEHEI5R7wspfyb8Axqy3UV8wfmh5H39eqriBhmDWQ0rtbmAIDv/Cu4LPJRlBEC/PqE A1EIujuozesWr6Jy8U97Brin63FNchRwGYLNq8djAC3eQeh1K66PzWbLA0E+XvfoNvG4 0LQ/8EKtagQLsy/G6oVwSrtNTCsk3DgTwVOMM9iPHFzGxFmk9rTakMDacV2TKIchTQsC /CxdcHSYjvoM49KhDak8I2FJP3/gwUq5UHWk6q2pshiPi/b+iJMHemgi43BMcasrfy5j 6dtCEgKir4KDApxS+LCvxHOUtIrP8xjsXSqdo+d/lgiGJrZMtnd25zowtaVDKIwKqyi7 XOCQ== X-Gm-Message-State: AIVw111/5oWVSdbs+z5vRW8kmmX+Vuj0Sy5moa6OYOfjK1/uEPqHcaoJ NMoHAsbkN4DoioqfIFAsTjKT1imFTQMv X-Received: by 10.107.176.11 with SMTP id z11mr21661325ioe.173.1500316024741; Mon, 17 Jul 2017 11:27:04 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.212.167 with HTTP; Mon, 17 Jul 2017 11:27:04 -0700 (PDT) X-Originating-IP: [65.151.16.249] In-Reply-To: <201707171812.v6HIC9Cq082059@repo.freebsd.org> References: <201707171812.v6HIC9Cq082059@repo.freebsd.org> From: Warner Losh Date: Mon, 17 Jul 2017 12:27:04 -0600 X-Google-Sender-Auth: OaA6vTek1-Ri3zojCfXPWCbYNnQ Message-ID: Subject: Re: svn commit: r321080 - head/usr.bin/getconf To: Ngie Cooper Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 18:27:06 -0000 On Mon, Jul 17, 2017 at 12:12 PM, Ngie Cooper wrote: > Author: ngie > Date: Mon Jul 17 18:12:08 2017 > New Revision: 321080 > URL: https://svnweb.freebsd.org/changeset/base/321080 > > Log: > Expose the ILP32/LP64 programming environments based on > __ILP32__/__LP64__ instead of by architecture. > > The list was incomplete (previous commits purged invalid architectures, > like __alpha__, but failed to add new ones). It's best to base the symbol > presence on whether or not the architecture is ILP32 / LP64 capable, per > the compiler. > > This fixes the ILP32/LP64 program environments on some architectures like > arm64, and by proxy fixes the tests on those architectures. > > MFC after: 1 month > Reviewed by: no one (timed out on feedback from imp) > You timed out because you never answered my question about other platforms. Warner > Differential Revision: D10787 > > Modified: > head/usr.bin/getconf/progenv.gperf > > Modified: head/usr.bin/getconf/progenv.gperf > ============================================================ > ================== > --- head/usr.bin/getconf/progenv.gperf Mon Jul 17 18:07:53 2017 > (r321079) > +++ head/usr.bin/getconf/progenv.gperf Mon Jul 17 18:12:08 2017 > (r321080) > @@ -30,11 +30,11 @@ static const struct map *in_word_set(const char *str); > * be updated. (We cheat here and define the supported environments > * statically.) > */ > -#if defined(__sparc64__) || defined(__amd64__) > +#ifdef __LP64__ > #define have_LP64_OFF64 NULL > #endif > > -#if defined(__i386__) || defined(__powerpc__) > +#ifdef __ILP32__ > #define have_ILP32_OFFBIG NULL > #endif > > >