From owner-svn-ports-all@freebsd.org  Fri Nov  2 02:53:52 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8A8410E243A;
 Fri,  2 Nov 2018 02:53:52 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D90472B66;
 Fri,  2 Nov 2018 02:53:52 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 5885014293; Fri,  2 Nov 2018 02:53:52 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Mark Linimon <linimon@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r483761 - in head/games/blokish: . files
References: <201811020146.wA21kPiS042920@repo.freebsd.org>
Date: Fri, 02 Nov 2018 03:53:49 +0100
In-Reply-To: <201811020146.wA21kPiS042920@repo.freebsd.org> (Mark Linimon's
 message of "Fri, 2 Nov 2018 01:46:25 +0000 (UTC)")
Message-ID: <d0ro-gpfm-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Nov 2018 02:53:52 -0000

Mark Linimon <linimon@FreeBSD.org> writes:

> Author: linimon
> Date: Fri Nov  2 01:46:24 2018
> New Revision: 483761
> URL: https://svnweb.freebsd.org/changeset/ports/483761
>
> Log:
>   This port needs USES=compiler:c++11-lang to build on GCC architectures.
>   
>   To build with GCC, it also needs algorithm and sys/limits.h includes.

Documenting the error is more important than paraphrasing the patch.

src/ai.cpp: In member function 'void AI::Reset(AI::AIOptions, BlokishID, std::vector<std::vector<BlokishPiece*>*>&)':
src/ai.cpp:50:15: error: 'INT_MIN' was not declared in this scope
   maxRating = INT_MIN;
               ^~~~~~~
src/ai.cpp:50:15: note: 'INT_MIN' is defined in header '<climits>'; did you forget to '#include <climits>'?
src/ai.cpp:26:1:
+#include <climits>

src/ai.cpp:50:15:
   maxRating = INT_MIN;
               ^~~~~~~
src/ai.cpp: In member function 'AI::StepOutcome AI::Step(BlokishBoard::Move&)':
src/ai.cpp:99:8: error: 'sort' is not a member of 'std'
   std::sort(possible_moves.begin(), possible_moves.end());
        ^~~~
src/ai.cpp:99:8: note: suggested alternative: 'cout'
   std::sort(possible_moves.begin(), possible_moves.end());
        ^~~~
        cout
src/ai.cpp: In member function 'void AI::Try()':
src/ai.cpp:122:28: error: 'INT_MAX' was not declared in this scope
       int maxCenterScore = INT_MAX;
                            ^~~~~~~
src/ai.cpp:122:28: note: 'INT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?

> ++#include <algorithm>
> ++#include <sys/limits.h>
> + #include "ai.h"

- <sys/limits.h> is not in POSIX unlike <limits.h>
- "ai.h" doesn't need the fix unlike ai.cpp, so move both below