From owner-svn-src-head@freebsd.org Tue Jan 19 13:57:01 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED20AA88987; Tue, 19 Jan 2016 13:57:01 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id B7A5A1A2A; Tue, 19 Jan 2016 13:57:01 +0000 (UTC) (envelope-from des@des.no) Received: from desk.des.no (smtp.des.no [194.63.250.102]) by smtp.des.no (Postfix) with ESMTP id 1796F5F71; Tue, 19 Jan 2016 13:57:00 +0000 (UTC) Received: by desk.des.no (Postfix, from userid 1001) id AEE4746FE0; Tue, 19 Jan 2016 14:56:55 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291941 - in head: lib/libpam/modules/pam_ssh secure/lib/libssh secure/libexec/sftp-server secure/libexec/ssh-keysign secure/libexec/ssh-pkcs11-helper secure/usr.bin/scp secure/usr.bin/... References: <201512071608.tB7G89BZ095366@repo.freebsd.org> Date: Tue, 19 Jan 2016 14:56:55 +0100 In-Reply-To: <201512071608.tB7G89BZ095366@repo.freebsd.org> (Bryan Drewery's message of "Mon, 7 Dec 2015 16:08:09 +0000 (UTC)") Message-ID: <86vb6phdug.fsf@desk.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2016 13:57:02 -0000 Bryan Drewery writes: > Log: > Replace unneeded manual dependency on header by adding it to SRCS. >=20=20=20 > bsd.lib.mk and bsd.prog.mk already depend all objs on headers in SRCS if > there is not yet a depend file. The headers in SRCS are never built or > installed. After 'make depend' the header was already added as a proper > dependency on the objects where needed. This doesn't work. Try the following: $ cd /usr/src/secure/lib/libssh $ make depend && make $ touch /usr/src/crypto/openssh/ssh_namespace.h $ make The second "make" should rebuild everything, but it doesn't. Also, $ grep -c ssh_namespace $(make -V.OBJDIR)/.depend 0 DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no