From nobody Wed Mar 19 20:44:13 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZJ10H0gfcz5qfy1; Wed, 19 Mar 2025 20:44:15 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZJ10G16qLz49yh; Wed, 19 Mar 2025 20:44:14 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742417054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cbApILZd5CYTyr0m7L1gXktzxk8QoNRX3SGJgkikOqU=; b=b8NtZsW23jNwIdjrVNkLDatsn8gz5DMKNmSZSWgRF3rb2rWWTYMVGNkszJtlReXUrZ84QK /mSHu7ZUGQBytppBqFANxJzkKY/FnUVnx0IcojKyDVjWLlxlzzZkoSRjX936AC9ngcsM3R c3N9DUQeW+8VZKfPFc1a6TcZx67YVPepp5UXrLCUDnNIyUJ9xGLOh4cDOwQGpvqA9nR+9G DHn85Pc9m3au5Jjp31lK3nrlq8wP/MdyXHN19kogWgh14E9U0tF4sK9vwBvNFn43bWLyTX Zetv3Wo2EUR+p4Wy1RC7fuAbvFqPnMhwNmgrqEWS4e+iFECzdlN+OjvfGohw7A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742417054; a=rsa-sha256; cv=none; b=Y0z42RpuzB3JWIxNnjFCW24Nhfxd9dXYgCDBlyEThw/F6OHAfUYdX3ECXh9+xGdH7Pz9m2 +05Q/rc83l0Pvj0nXiGKLM5AQ5ddidAFqxrLIX89TJAIon6rhdoxUaOtEfefJbK0CA+jdP ZH84ET5JfjwW/4zRp+9ycoJJM4CNClj4ovCLLHjkKLG3dKY/IQ+CnPBm+zf/2ssbn5N0e1 4jHIEktdsUpZgYojFuTS7uM/J0qu3qrGqp+c7v845SYmfuNo+x2UYhDKQaF5EdLe0ACBbr qJl9rE8+xMk4JQ93//ieoanUxsH6MUMDXQ3+7SXb3aSuVDqtc9YjyOKCcj9qIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742417054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cbApILZd5CYTyr0m7L1gXktzxk8QoNRX3SGJgkikOqU=; b=jS2kQp+qIhyccStUw4M3FDDF/sbFoa/HMTqU4BdPRo80qkGePeEzU/Y8NIUJSYB3HY959B 7BKAagNmfjRZnXbk9izi9d6C8LsD6wEXrf0H7l3u4ESZMCjdhVDYLVltlY8bh4axARnw9D SpDnHZyU63jOQWWENUaOqwu1lYaKuwSKANbMvQutm3AaDc63Wee/DL4QtKFkZDA0L2r1aO F6bq77uURXTe872YTkx5uYvYOaYqByEsg589PHtNpolErQTRrAufSB6yxRhppwpeAtJvaj AcXuZ82hLpFc4/QDznKyfy2LSTvTlxNLLw8u2u1u9KMH43YRcwLBjLuk42Uohw== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZJ10G0GrtztLM; Wed, 19 Mar 2025 20:44:14 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 843C23C01A0; Wed, 19 Mar 2025 20:44:13 +0000 (UTC) Date: Wed, 19 Mar 2025 20:44:13 +0000 From: Brooks Davis To: Chuck Silvers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 623be660fcc9 - main - beep: add missing include of src.opts.mk, use LIBADD instead of LDFLAGS Message-ID: References: <202503192022.52JKMaUG019132@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202503192022.52JKMaUG019132@gitrepo.freebsd.org> On Wed, Mar 19, 2025 at 08:22:36PM +0000, Chuck Silvers wrote: > The branch main has been updated by chs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=623be660fcc9860c0e8b99e8c2c4bbdefc121fd1 > > commit 623be660fcc9860c0e8b99e8c2c4bbdefc121fd1 > Author: Chuck Silvers > AuthorDate: 2025-03-19 19:48:10 +0000 > Commit: Chuck Silvers > CommitDate: 2025-03-19 19:48:10 +0000 > > beep: add missing include of src.opts.mk, use LIBADD instead of LDFLAGS > > Sponsored by: Netflix > --- > usr.bin/beep/Makefile | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/usr.bin/beep/Makefile b/usr.bin/beep/Makefile > index f252ab64f843..8388ff7ff986 100644 > --- a/usr.bin/beep/Makefile > +++ b/usr.bin/beep/Makefile > @@ -1,6 +1,7 @@ > +.include Why add src.opts.mk? Nothing is using it and bsd.prog.mk will include it. Is there another change coming that will use it? -- Brooks > + > PROG= beep > MAN= beep.1 > - > -LDFLAGS= -lm > +LIBADD= m > > .include >