From owner-svn-ports-all@FreeBSD.ORG Sat Oct 12 18:49:16 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 104A21F4; Sat, 12 Oct 2013 18:49:16 +0000 (UTC) (envelope-from kozlov@ravenloft.kiev.ua) Received: from ravenloft.kiev.ua (ravenloft.kiev.ua [94.244.131.95]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BBC382BA2; Sat, 12 Oct 2013 18:49:14 +0000 (UTC) Date: Sat, 12 Oct 2013 21:49:12 +0300 From: Alex Kozlov To: Bryan Drewery Subject: Re: svn commit: r327601 - head/Mk Message-ID: <20131012184912.GA31756@ravenloft.kiev.ua> References: <201309190805.r8J855cW009011@svn.freebsd.org> <20130921023225.GA19307@FreeBSD.org> <20130921104936.GQ73535@ithaqua.etoilebsd.net> <523D7B20.6020908@FreeBSD.org> <52589A4E.3070506@FreeBSD.org> <52591EAF.2040201@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52591EAF.2040201@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , Gerald Pfeifer , Eitan Adler , svn-ports-all@freebsd.org, Baptiste Daroussin , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Oct 2013 18:49:16 -0000 On Sat, Oct 12, 2013 at 05:04:31AM -0500, Bryan Drewery wrote: > On 10/12/2013 1:20 AM, Eitan Adler wrote: > > On Fri, Oct 11, 2013 at 8:39 PM, Bryan Drewery wrote: > >>> I thought we all are supposed to run portlint before commits? > >> Yes, but it's severely outdated and no one has stepped up to fix that or > >> take proper maintainership of it. It currently gives incorrect advice on > >> multiple common cases. > > ak@ has done a bunch of work on portlint and I believe he is just > > waiting on maintainer approval. > ak has done fine work, but I don't see any current patches from him > waiting for maintainer response. I do see a USE_GMAKE fix that I am > committing now from someone else. Sorry about that. I've asked on irc for suggestions/review a few times, but perhaps I should have also write a mail to ports@ ML. Anyway, here is the patch: http://people.freebsd.org/~ak/patch-portlint.txt -- Alex