From owner-freebsd-current Mon Sep 28 10:00:28 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA12083 for freebsd-current-outgoing; Mon, 28 Sep 1998 10:00:28 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA12048 for ; Mon, 28 Sep 1998 10:00:22 -0700 (PDT) (envelope-from toor@dyson.iquest.net) Received: (from root@localhost) by dyson.iquest.net (8.8.8/8.8.8) id LAA02291; Mon, 28 Sep 1998 11:59:42 -0500 (EST) (envelope-from toor) Message-Id: <199809281659.LAA02291@dyson.iquest.net> Subject: Re: VM question Re m->valid ... In-Reply-To: from "Robert V. Baron" at "Sep 28, 98 10:46:45 am" To: rvb@cs.cmu.edu (Robert V. Baron) Date: Mon, 28 Sep 1998 11:59:42 -0500 (EST) Cc: tlambert@primenet.com, current@FreeBSD.ORG, dyson@iquest.net From: "John S. Dyson" Reply-To: dyson@iquest.net X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Robert V. Baron said: > > The change mentioned below does not solve my problem. I have > two ways to go. I'd like feed back and will commit something > later today. > > There are two ways to go. One is to have vnode_pager_input_old > set m->valid iff there are no errors. This works fine for me. > The down side is that it is touching possibly sensitive code > close to a release. I don't think this is a problem because > it looks like only coda, msdos and cd9660 use the > vnode_pager_generic_getpage interface. The latter two provide > a bmap function that does not appear to return 0. So I believe > that vnode_pager_input_old is only currently called by Coda. > I suspect that setting m->valid iff there are no errors is the correct behavior!!! :-). -- John | Never try to teach a pig to sing, dyson@iquest.net | it makes one look stupid jdyson@nc.com | and it irritates the pig. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message