From nobody Sun Jan 11 23:18:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqBJf09z6z6Ng3V for ; Sun, 11 Jan 2026 23:18:26 +0000 (UTC) (envelope-from ctuffli@gmail.com) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqBJd29Sgz49Vs for ; Sun, 11 Jan 2026 23:18:25 +0000 (UTC) (envelope-from ctuffli@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of ctuffli@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=ctuffli@gmail.com Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-81f3c14027cso650994b3a.1 for ; Sun, 11 Jan 2026 15:18:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768173503; x=1768778303; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M8HkODoNvUiuShebxlYa55EziAHQDlCTZbo9b7KE5/s=; b=kzADff7Fh9W61c4PD5ekoPotGCtNibG/eqF7qDURaJ7s1tApfJAKtEqchaUgqnsbO0 O3NZAW4JYAa3Z59tMjoS5MpM/ehBvM1SfeqDvYXO6Zc68jt8NNMeTBs0EMokmqVsYRoL X09BU8XFxWad025zJ7PDVTsc/9IjdeIyk9XV29FwUkrZ5VtHBRbWGh91TyqW9SkVXcUH gOcw94/Z5uUYRikkWUC9TR8bkld6urJmrqhdFrJOoevubcj8MyYUzyVLQB8QfQHPKU27 EgyveB1jqPIgiGh5NrtO3vOiuWhjqw2wuItc3VWmQ1cmaOOKNAW3YulfXtMZscavn3gr rn+Q== X-Forwarded-Encrypted: i=1; AJvYcCXTzFCMcdSeEyIU5RJVBWTsaj352iCeUcQ314Yl3zKXtH/t8QsTm+dmcmOPZyqyVVxdP3FKLRXFM+Tj8u0pXAWRfRIX@freebsd.org X-Gm-Message-State: AOJu0YwyH1RI74Zn0flZzwUtJFyDqtHRyUklHcKmHNWt1ST6LPdaT31d FyW1l94bqQVykHqMliWTcWp3Zk3xc5HachzfMJByALDPTu2rYXYIKIL2zT4yKg== X-Gm-Gg: AY/fxX51C5yMRETPOCxsZaxav3uFCe0vTimG98hAyrCTNlu91JccCCEdvLZUeI6jNjq b4fh95+wRL3pU3FKMio4cq+Hknp6svKtMSf+SRp9GuQPCmIkH+S/mLobglXC2AR6+pcCADgEM7k W9lQOZMTlt3UPWVBdlYFtfRQyqLnoKAzwdRiqQ9QSuisUoc/YDXuE4oujIROdutRMgPpAprgdOk rvsP/o+Wnec9vHvHPher532kSmWY0dj0E2W51BYG0n2jBUfdCvV92gTjj/yaOluX73taOtJ0Utq P/xvAIABRl6+GawwOV7bGzq0Olcyzs6C/7UbIukt4xJ0cTSwYCagaSCnaCV28baNhOzJwaQS+c4 0gW7yDb2Des83e3tTIHoz7G3kfpNPRLGHbiRaGJYjSwdilajynFO/TTm3jvr9Zghajva4r8v5DX MKiSVUNdvrVom+/lKFFcLP5lElNlRsAD/6trbOW8ECsByN X-Google-Smtp-Source: AGHT+IFbdDq9khMHzdrVnS0dnLxDf5CkcgxWOPDNzREcrW8FXJK8ZWxMjRwylR6DqC5yvpX+6vu8pg== X-Received: by 2002:a05:6a00:1256:b0:81f:57db:a459 with SMTP id d2e1a72fcca58-81f57dba50dmr1145457b3a.29.1768173502974; Sun, 11 Jan 2026 15:18:22 -0800 (PST) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com. [209.85.216.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c52fc9bdsm15772132b3a.32.2026.01.11.15.18.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Jan 2026 15:18:22 -0800 (PST) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-34ccdcbe520so2399835a91.1 for ; Sun, 11 Jan 2026 15:18:22 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUP3oIN9WRrLLy1HrxT4G/XgDjuqm20xfl+uBpkS+gpnTrhmM8bJiyvlYqzT9WFuM6ODODwLszs1Caz3DFyTeH+tR/E@freebsd.org X-Received: by 2002:a17:90b:2e8f:b0:343:3898:e7c7 with SMTP id 98e67ed59e1d1-34f68c010d0mr14449473a91.12.1768173502378; Sun, 11 Jan 2026 15:18:22 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <69616257.8255.cd9e3ac@gitrepo.freebsd.org> In-Reply-To: <69616257.8255.cd9e3ac@gitrepo.freebsd.org> From: Chuck Tuffli Date: Sun, 11 Jan 2026 15:18:11 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_QhTvQzpHAVtsh6-SGCggImBpJrNu9PomM10A91_hYZ14cm3uIr2rrQUvbo Message-ID: Subject: Re: git: 763179042246 - main - Fix NULL deref segfault in bhyve's usb_mouse.c To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jack Bendtsen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Spamd-Result: default: False [-0.32 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997]; NEURAL_SPAM_LONG(0.80)[0.799]; FORGED_SENDER(0.30)[chuck@freebsd.org,ctuffli@gmail.com]; NEURAL_HAM_SHORT(-0.22)[-0.218]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[chuck@freebsd.org,ctuffli@gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.210.172:from,209.85.216.54:received]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.210.172:from]; R_DKIM_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4dqBJd29Sgz49Vs On Fri, Jan 9, 2026 at 12:18=E2=80=AFPM Warner Losh wrote= : > > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D7631790422464de1aec309018e= 2c444defe5f629 > > commit 7631790422464de1aec309018e2c444defe5f629 > Author: Jack Bendtsen > AuthorDate: 2025-06-19 07:40:31 +0000 > Commit: Warner Losh > CommitDate: 2026-01-09 20:17:13 +0000 > > Fix NULL deref segfault in bhyve's usb_mouse.c > > Some of the cases inside umouse_request() (usr.sbin/bhyve/usb_mouse.c= ) > use the data component of an event, while only partially checking if > it's NULL. 'data' has a NULL check, but then 'data' is immediately > deferenced anyway after the check regardless of if it's NULL or not. The SmartOS/Illumos folks ran into this issue a bit ago and fixed their version of bhyve differently (https://www.illumos.org/issues/17784). This has been on my to-do list, but it didn't make it to the top before this (point hat: chuck@). Any concerns or objections to my committing https://reviews.freebsd.org/D54661 to minimize our diffs with SmartOS/illumos? --chuck